Re: [PATCH 3/3] btrfs-progs: Add command to check if balance op is req

2016-11-01 Thread divya . indi
On 10/31/2016 09:33 AM, David Sterba wrote: On Fri, Oct 28, 2016 at 05:29:45PM +0100, Graham Cobb wrote: On 28/10/16 16:20, David Sterba wrote: I tend to agree with this approach. The usecase, with some random sample balance options: $ btrfs balance start --analyze -dusage=10 -musage=5

Re: [PATCH 3/3] btrfs-progs: Add command to check if balance op is req

2016-10-31 Thread David Sterba
On Fri, Oct 28, 2016 at 05:29:45PM +0100, Graham Cobb wrote: > On 28/10/16 16:20, David Sterba wrote: > > I tend to agree with this approach. The usecase, with some random sample > > balance options: > > > > $ btrfs balance start --analyze -dusage=10 -musage=5 /path > > Wouldn't a "balance

Re: [PATCH 3/3] btrfs-progs: Add command to check if balance op is req

2016-10-30 Thread Qu Wenruo
On 10/28/2016 11:20 PM, David Sterba wrote: On Wed, Oct 19, 2016 at 10:08:23AM -0700, Divya Indi wrote: On 10/17/2016 06:42 PM, Qu Wenruo wrote: At 10/18/2016 08:35 AM, Divya Indi wrote: Add new subcommand to btrfs inspect-internal btrfs inspect-internal balance_check Checks whether

Re: [PATCH 3/3] btrfs-progs: Add command to check if balance op is req

2016-10-28 Thread Graham Cobb
On 28/10/16 16:20, David Sterba wrote: > I tend to agree with this approach. The usecase, with some random sample > balance options: > > $ btrfs balance start --analyze -dusage=10 -musage=5 /path Wouldn't a "balance analyze" command be better than "balance start --analyze"? I would have guessed

Re: [PATCH 3/3] btrfs-progs: Add command to check if balance op is req

2016-10-28 Thread David Sterba
On Wed, Oct 19, 2016 at 10:08:23AM -0700, Divya Indi wrote: > On 10/17/2016 06:42 PM, Qu Wenruo wrote: > > At 10/18/2016 08:35 AM, Divya Indi wrote: > >> Add new subcommand to btrfs inspect-internal > >> > >> btrfs inspect-internal balance_check > >> Checks whether 'btrfs balance' can help

Re: [PATCH 3/3] btrfs-progs: Add command to check if balance op is req

2016-10-19 Thread Divya Indi
On 10/17/2016 06:42 PM, Qu Wenruo wrote: At 10/18/2016 08:35 AM, Divya Indi wrote: Add new subcommand to btrfs inspect-internal btrfs inspect-internal balance_check Checks whether 'btrfs balance' can help creating more space (Only considers data block groups). I didn't think it's good to

Re: [PATCH 3/3] btrfs-progs: Add command to check if balance op is req

2016-10-17 Thread Qu Wenruo
At 10/18/2016 08:35 AM, Divya Indi wrote: Add new subcommand to btrfs inspect-internal btrfs inspect-internal balance_check Checks whether 'btrfs balance' can help creating more space (Only considers data block groups). I didn't think it's good to add a new subcommand just for that. Why

[PATCH 3/3] btrfs-progs: Add command to check if balance op is req

2016-10-17 Thread Divya Indi
Add new subcommand to btrfs inspect-internal btrfs inspect-internal balance_check Checks whether 'btrfs balance' can help creating more space (Only considers data block groups). Signed-off-by: Divya Indi Reviewed-by: Ashish Samant Reviewed-by: