Re: [PATCH V2] btrfs: fix possible deadlock by clearing __GFP_FS flag

2011-03-28 Thread Miao Xie
On tue, 29 Mar 2011 14:48:05 +0900, Itaru Kitayama wrote: > Hi Miao, > > On Sun, 27 Mar 2011 20:27:30 +0800 > Miao Xie wrote: > >> Changelog V1 -> V2: >> - modify the explanation of the deadlock. >> - clear __GFP_FS flag in the free space's page cache. > > I think this is also needed on top of

Re: [PATCH V2] btrfs: fix possible deadlock by clearing __GFP_FS flag

2011-03-28 Thread Itaru Kitayama
Hi Miao, On Sun, 27 Mar 2011 20:27:30 +0800 Miao Xie wrote: > Changelog V1 -> V2: > - modify the explanation of the deadlock. > - clear __GFP_FS flag in the free space's page cache. I think this is also needed on top of your V5 patch to avoid a recursion. Could you review it and give your Sign

Re: [PATCH V2] btrfs: fix possible deadlock by clearing __GFP_FS flag

2011-03-27 Thread Chris Mason
Excerpts from Miao Xie's message of 2011-03-27 08:27:30 -0400: > Changelog V1 -> V2: > - modify the explanation of the deadlock. > - clear __GFP_FS flag in the free space's page cache. > > diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c > index a039065..57df380 100644 > ---

[PATCH V2] btrfs: fix possible deadlock by clearing __GFP_FS flag

2011-03-27 Thread Miao Xie
Changelog V1 -> V2: - modify the explanation of the deadlock. - clear __GFP_FS flag in the free space's page cache. Using the GFP_HIGHUSER_MOVABLE flag to allocate the metadata's page may cause deadlock. Task1 open() ... btrfs_search_slot() ... btrfs_cow_block() ...