Re: [PATCH v2] Btrfs: improve multi-thread buffer read

2012-07-13 Thread Chris Mason
On Thu, Jul 12, 2012 at 08:52:15PM -0600, Liu Bo wrote: On 07/12/2012 02:04 PM, Chris Mason wrote: I like this patch, its a big improvement for just a little timing change. Instead of doing the kmalloc of this struct, can you please change it to put a pagevec on the stack. The model

Re: [PATCH v2] Btrfs: improve multi-thread buffer read

2012-07-12 Thread Chris Mason
On Wed, Jul 11, 2012 at 08:13:51PM -0600, Liu Bo wrote: While testing with my buffer read fio jobs[1], I find that btrfs does not perform well enough. Here is a scenario in fio jobs: We have 4 threads, t1 t2 t3 t4, starting to buffer read a same file, and all of them will race on

Re: [PATCH v2] Btrfs: improve multi-thread buffer read

2012-07-12 Thread Liu Bo
On 07/12/2012 02:04 PM, Chris Mason wrote: On Wed, Jul 11, 2012 at 08:13:51PM -0600, Liu Bo wrote: While testing with my buffer read fio jobs[1], I find that btrfs does not perform well enough. Here is a scenario in fio jobs: We have 4 threads, t1 t2 t3 t4, starting to buffer read a same

[PATCH v2] Btrfs: improve multi-thread buffer read

2012-07-11 Thread Liu Bo
While testing with my buffer read fio jobs[1], I find that btrfs does not perform well enough. Here is a scenario in fio jobs: We have 4 threads, t1 t2 t3 t4, starting to buffer read a same file, and all of them will race on add_to_page_cache_lru(), and if one thread successfully puts its page