Re: [PATCH v2] Btrfs: return failure if btrfs_dev_replace_finishing() failed

2014-10-13 Thread Eryu Guan
On Mon, Oct 13, 2014 at 06:18:04PM +0800, Anand Jain wrote: > > > On 10/13/14 14:59, Eryu Guan wrote: > >On Mon, Oct 13, 2014 at 02:23:57PM +0800, Anand Jain wrote: > >> > >> > >>comments below.. > >> > >> > >>On 10/13/14 12:42, Eryu Guan wrote: > >>>device replace could fail due to another runni

Re: [PATCH v2] Btrfs: return failure if btrfs_dev_replace_finishing() failed

2014-10-13 Thread Anand Jain
On 10/13/14 14:59, Eryu Guan wrote: On Mon, Oct 13, 2014 at 02:23:57PM +0800, Anand Jain wrote: comments below.. On 10/13/14 12:42, Eryu Guan wrote: device replace could fail due to another running scrub process or any other errors btrfs_scrub_dev() may hit, but this failure doesn't get r

Re: [PATCH v2] Btrfs: return failure if btrfs_dev_replace_finishing() failed

2014-10-13 Thread Eryu Guan
On Mon, Oct 13, 2014 at 02:23:57PM +0800, Anand Jain wrote: > > > comments below.. > > > On 10/13/14 12:42, Eryu Guan wrote: > >device replace could fail due to another running scrub process or any > >other errors btrfs_scrub_dev() may hit, but this failure doesn't get > >returned to userspace.

Re: [PATCH v2] Btrfs: return failure if btrfs_dev_replace_finishing() failed

2014-10-12 Thread Anand Jain
comments below.. On 10/13/14 12:42, Eryu Guan wrote: device replace could fail due to another running scrub process or any other errors btrfs_scrub_dev() may hit, but this failure doesn't get returned to userspace. The following steps could reproduce this issue mkfs -t btrfs -f /dev

[PATCH v2] Btrfs: return failure if btrfs_dev_replace_finishing() failed

2014-10-12 Thread Eryu Guan
device replace could fail due to another running scrub process or any other errors btrfs_scrub_dev() may hit, but this failure doesn't get returned to userspace. The following steps could reproduce this issue mkfs -t btrfs -f /dev/sdb1 /dev/sdb2 mount /dev/sdb1 /mnt/btrfs