Re: [PATCH v3] Btrfs: add label to snapshot and subvol

2012-11-28 Thread Anand Jain
On 11/28/2012 11:05 AM, Miao Xie wrote: On wed, 28 Nov 2012 02:29:17 +0800, Anand jain wrote: /* @@ -2441,6 +2443,14 @@ static inline bool btrfs_root_readonly(struct btrfs_root *root) { return (root-root_item.flags cpu_to_le64(BTRFS_ROOT_SUBVOL_RDONLY)) != 0; } +static inline

Re: [PATCH v3] Btrfs: add label to snapshot and subvol

2012-11-28 Thread Miao Xie
On wed, 28 Nov 2012 18:02:56 +0800, Anand Jain wrote: On 11/28/2012 11:05 AM, Miao Xie wrote: On wed, 28 Nov 2012 02:29:17 +0800, Anand jain wrote: /* @@ -2441,6 +2443,14 @@ static inline bool btrfs_root_readonly(struct btrfs_root *root) { return (root-root_item.flags

[PATCH v3] Btrfs: add label to snapshot and subvol

2012-11-28 Thread Anand jain
From: Anand Jain anand.j...@oracle.com Signed-off-by: Anand Jain anand.j...@oracle.com Reviewed-by: Jan Schmidt list.bt...@jan-o-sch.net Reviewed-by: Miao Xie mi...@cn.fujitsu.com --- fs/btrfs/ctree.h | 12 +- fs/btrfs/ioctl.c | 58

Re: [PATCH v3] Btrfs: add label to snapshot and subvol

2012-11-28 Thread Anand Jain
Miao, Thanks for the review. A new patch was sent. Anand On 11/28/2012 06:25 PM, Miao Xie wrote: On wed, 28 Nov 2012 18:02:56 +0800, Anand Jain wrote: On 11/28/2012 11:05 AM, Miao Xie wrote: On wed, 28 Nov 2012 02:29:17 +0800, Anand jain wrote: /* @@ -2441,6 +2443,14 @@ static

[PATCH v3] Btrfs: add label to snapshot and subvol

2012-11-27 Thread Anand jain
From: Anand Jain anand.j...@oracle.com v3-v2: accepts Miao' review comment. Signed-off-by: Anand Jain anand.j...@oracle.com Reviewed-by: Jan Schmidt list.bt...@jan-o-sch.net Reviewed-by: Miao Xie mi...@cn.fujitsu.com --- fs/btrfs/ctree.h | 12 +- fs/btrfs/ioctl.c | 55

Re: [PATCH v3] Btrfs: add label to snapshot and subvol

2012-11-27 Thread Miao Xie
On wed, 28 Nov 2012 02:29:17 +0800, Anand jain wrote: /* @@ -2441,6 +2443,14 @@ static inline bool btrfs_root_readonly(struct btrfs_root *root) { return (root-root_item.flags cpu_to_le64(BTRFS_ROOT_SUBVOL_RDONLY)) != 0; } +static inline char * btrfs_root_label(struct