On Wed, 13 Apr 2011 07:32:59 -0400
Chris Mason wrote:
> This is in the master branch now, please give it another test. Thanks a
> lot for bisecting down and patching!
Tested on btrfs-unstable/master. Works correctly. Reverting
3387206f26e1b48703e810175b98611a4fd8e8ea (to make sure)
on top of ma
Excerpts from Sergei Trofimovich's message of 2011-04-12 17:23:33 -0400:
> On Mon, 11 Apr 2011 15:50:48 -0400
> Josef Bacik wrote:
>
> > On 04/11/2011 03:44 PM, Sergei Trofimovich wrote:
> > >> Fix data corruption caused by memcpy() usage on overlapping data.
> > >> I've observed it first when fo
On Mon, 11 Apr 2011 15:50:48 -0400
Josef Bacik wrote:
> On 04/11/2011 03:44 PM, Sergei Trofimovich wrote:
> >> Fix data corruption caused by memcpy() usage on overlapping data.
> >> I've observed it first when found out usermode linux crash on btrfs.
...
> Fair enough, BUG_ON() it is. Repost t
On 04/11/2011 03:44 PM, Sergei Trofimovich wrote:
Fix data corruption caused by memcpy() usage on overlapping data.
I've observed it first when found out usermode linux crash on btrfs.
Changes since v2:
- Code style cleanup
- 2 versions of patch: BUG_ON and WARN_ON variants,
_but_ see below
I think the problem here is that memcpy beahviour changed in recent
glibc in this regard see here http://lwn.net/Articles/414467/
On Mon, 2011-04-11 at 22:44 +0300, Sergei Trofimovich wrote:
> > Fix data corruption caused by memcpy() usage on overlapping data.
> > I've observed it first when foun
> Fix data corruption caused by memcpy() usage on overlapping data.
> I've observed it first when found out usermode linux crash on btrfs.
Changes since v2:
- Code style cleanup
- 2 versions of patch: BUG_ON and WARN_ON variants,
_but_ see below why I prefer BUG_ON
Changes since v1:
>
