Re: [PATCH v3] xfstests: btrfs/316: cross-subvolume sparse copy

2013-07-03 Thread Dave Chinner
On Tue, Jul 02, 2013 at 11:51:21AM -0400, Eric Sandeen wrote: On Jul 2, 2013, at 10:28 AM, Koen De Wit koen.de@oracle.com wrote: Dave, Thanks for the review. I will clean up the commit message and do a full mail-to-myself-and-test-patch round trip to avoid errors like the wrong

Re: [PATCH v3] xfstests: btrfs/316: cross-subvolume sparse copy

2013-07-03 Thread Koen De Wit
On 07/03/2013 08:37 AM, Dave Chinner wrote: On Tue, Jul 02, 2013 at 11:51:21AM -0400, Eric Sandeen wrote: On Jul 2, 2013, at 10:28 AM, Koen De Wit koen.de@oracle.com wrote: Dave, Thanks for the review. I will clean up the commit message and do a full mail-to-myself-and-test-patch

Re: [PATCH v3] xfstests: btrfs/316: cross-subvolume sparse copy

2013-07-03 Thread Dave Chinner
On Wed, Jul 03, 2013 at 12:02:52PM +0200, Koen De Wit wrote: On 07/03/2013 08:37 AM, Dave Chinner wrote: On Tue, Jul 02, 2013 at 11:51:21AM -0400, Eric Sandeen wrote: On Jul 2, 2013, at 10:28 AM, Koen De Wit koen.de@oracle.com wrote: Dave, Thanks for the review. I will clean

[PATCH v3] xfstests: btrfs/316: cross-subvolume sparse copy

2013-07-02 Thread Koen De Wit
This testscript creates reflinks to files on different subvolumes, overwrites the original files and reflinks, and moves reflinked files between subvolumes. Originally submitted as testcase 302, changes are made based on comments from Eric: http://oss.sgi.com/archives/xfs/2013-03/msg00231.html

Re: [PATCH v3] xfstests: btrfs/316: cross-subvolume sparse copy

2013-07-02 Thread Dave Chinner
On Tue, Jul 02, 2013 at 11:27:51AM +0200, Koen De Wit wrote: This testscript creates reflinks to files on different subvolumes, overwrites the original files and reflinks, and moves reflinked files between subvolumes. Originally submitted as testcase 302, changes are made based on comments

Re: [PATCH v3] xfstests: btrfs/316: cross-subvolume sparse copy

2013-07-02 Thread Koen De Wit
Dave, Thanks for the review. I will clean up the commit message and do a full mail-to-myself-and-test-patch round trip to avoid errors like the wrong test numbers in the golden output. I'm sorry for this. About cutting out file names from the output. I did this in the first version of the

Re: [PATCH v3] xfstests: btrfs/316: cross-subvolume sparse copy

2013-07-02 Thread Eric Sandeen
On Jul 2, 2013, at 10:28 AM, Koen De Wit koen.de@oracle.com wrote: Dave, Thanks for the review. I will clean up the commit message and do a full mail-to-myself-and-test-patch round trip to avoid errors like the wrong test numbers in the golden output. I'm sorry for this. About