Dear Nick,
Am 10.10.2018 um 22:28 schrieb Nick Terrell:
On Oct 10, 2018, at 12:34 AM, Paul Menzel wrote:
Sorry for being ignorant, but you explain, why the library needs to
be imported and it is not enough to use that library as an external
dependency?
Importing the library means, it has to be maintained in the GRUB
repository, which will result in some maintenance burden.
I've imported zstd because thats the way the rest of the
decompressors are imported.
We could potentially use libzstd as an external dependency, since its
only dependency is libc and GRUB provides the definitions of the libc
functions that zstd needs to decompress (memcpy, and memmove). Theres
some other stuff in the library that requires libc functionality that
GRUB doesn't provide, but that isn't used during decompression. We
strip those files out in the import.
Thank you for the explanation.
Let me know if you want me to switch to an external dependency.
I cannot make that decision. The main developers and the distribution
folks should comment on that.
Kind regards,
Paul
