Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-16 Thread Anand Jain
Johannes, Xavier, Can you pls send the output for .. cat /etc/fstab | egrep btrfs cat /proc/self/mounts | egrep btrfs mount | egrep btrfs Thanks, Anand On 16/09/2014 06:17, Johannes Hirte wrote: On Tue, 16 Sep 2014 01:39:49 +0800 Anand Jain anand.j...@oracle.com wrote: On

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-15 Thread Anand Jain
Hi Johannes, Can I have you this tested.. ? Thanks. --- diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index e9676a4..1224b61 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -533,7 +533,7 @@ static noinline int device_list_add(const char *path, * the

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-15 Thread Johannes Hirte
On Sun, 14 Sep 2014 00:45:49 + (UTC) Duncan 1i5t5.dun...@cox.net wrote: Johannes Hirte posted on Sat, 13 Sep 2014 23:23:20 +0200 as excerpted: On Sat, 13 Sep 2014 19:55:25 +0200 Johannes Hirte johannes.hi...@datenkhaos.de wrote: On Sat, 13 Sep 2014 13:36:37 +0800 Anand Jain

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-15 Thread Johannes Hirte
On Mon, 15 Sep 2014 20:32:58 +0800 Anand Jain anand.j...@oracle.com wrote: Hi Johannes, Can I have you this tested.. ? Thanks. --- diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index e9676a4..1224b61 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -533,7

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-15 Thread Anand Jain
On 16/09/2014 01:14, Johannes Hirte wrote: On Mon, 15 Sep 2014 20:32:58 +0800 Anand Jain anand.j...@oracle.com wrote: Hi Johannes, Can I have you this tested.. ? Thanks. --- diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index e9676a4..1224b61 100644 ---

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-15 Thread Johannes Hirte
On Tue, 16 Sep 2014 01:39:49 +0800 Anand Jain anand.j...@oracle.com wrote: On 16/09/2014 01:14, Johannes Hirte wrote: On Mon, 15 Sep 2014 20:32:58 +0800 Anand Jain anand.j...@oracle.com wrote: Hi Johannes, Can I have you this tested.. ? Thanks. --- diff --git

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-14 Thread xavier.gn...@gmail.com
The way an encrypted home is mounted is based on links as described here: https://help.ubuntu.com/community/EncryptedPrivateDirectory It used to be ok before 3.17-rc3 and df -h shows: /dev/sda5 363G 128G 217G 38% / /home/gnata/.Private 363G 128G 217G 38% /home/gnata It is

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-13 Thread Johannes Hirte
On Sat, 13 Sep 2014 13:36:37 +0800 Anand Jain anand.j...@oracle.com wrote: Xavier, Johannes, The quickest workaround for you will be to try to match the device path as in the btrfs fi show -m /mnt output to your probably fstab/mnttab entry. Doesn't work here. I don't even get a

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-13 Thread Johannes Hirte
On Sat, 13 Sep 2014 19:55:25 +0200 Johannes Hirte johannes.hi...@datenkhaos.de wrote: On Sat, 13 Sep 2014 13:36:37 +0800 Anand Jain anand.j...@oracle.com wrote: Xavier, Johannes, The quickest workaround for you will be to try to match the device path as in the btrfs fi show -m

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-13 Thread Duncan
Johannes Hirte posted on Sat, 13 Sep 2014 23:23:20 +0200 as excerpted: On Sat, 13 Sep 2014 19:55:25 +0200 Johannes Hirte johannes.hi...@datenkhaos.de wrote: On Sat, 13 Sep 2014 13:36:37 +0800 Anand Jain anand.j...@oracle.com wrote: The quickest workaround for you will be to try to match

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-12 Thread xavier.gn...@gmail.com
Hi, On standard ubuntu 14.04 a with an encrypted (cryptsetup) /home as brtfs subvolume we have the following results: 3.17-rc2 : Ok. 3.17-rc3 and 3.17-rc4 : /home fails to mount on boot. If one try mount -a then the system tells that the partition is already mounted according to matab.

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-12 Thread Anand Jain
Hi Xavier, Thanks for the report. I got this reproduced: its a very corner case, it depends on the device path given in the subsequent subvol mounts, the fix appear to be outside of this patch at this moment and I am digging to know if we need to normalize the device path before using it

Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-10 Thread Johannes Hirte
commit b96de000bc8bc9688b3a2abea4332bd57648a49f breaks subvolume mount on one of my systems. I've bisected a mount problem to this commit. Situation is: - one hdd with btrfs - default subvolume (rootfs) is different from subovlid=0 - at boot, several subvols are mounted at /home/$DIR after

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-10 Thread Anand Jain
that's shocking. Let me take a look. Thanks for reporting. Anand On 09/11/14 06:22 AM, Johannes Hirte wrote: commit b96de000bc8bc9688b3a2abea4332bd57648a49f breaks subvolume mount on one of my systems. I've bisected a mount problem to this commit. Situation is: - one hdd with btrfs -

Re: Btrfs: device_list_add() should not update list when mounted breaks subvol mount

2014-09-10 Thread Anand Jain
Hi Johannes, I've two more systems with kernel version 3.17-rc3 running and no problem like this. Does this 3.17-rc3 also has the same type of subvol config and it mount operation/sequence as you mentioned ? - one hdd with btrfs - default subvolume (rootfs) is different from subovlid=0