RE: [PATCH] btrfs: Remove code for no-cow in scrub/replace

2015-10-26 Thread Zhao Lei
Hi, Filipe Manana > -Original Message- > From: Filipe Manana [mailto:fdman...@gmail.com] > Sent: Friday, October 23, 2015 11:17 PM > To: Jeff Mahoney <je...@suse.com> > Cc: Zhao Lei <zhao...@cn.fujitsu.com>; linux-btrfs@vger.kernel.org > Subject: Re: [PATCH]

RE: [PATCH] btrfs: Remove code for no-cow in scrub/replace

2015-10-26 Thread Zhao Lei
Hi, Jeff Mahoney Thanks for review! > -Original Message- > From: Jeff Mahoney [mailto:je...@suse.com] > Sent: Friday, October 23, 2015 11:11 PM > To: Zhao Lei <zhao...@cn.fujitsu.com>; linux-btrfs@vger.kernel.org > Subject: Re: [PATCH] btrfs: Remove code for no

Re: [PATCH] btrfs: Remove code for no-cow in scrub/replace

2015-10-23 Thread Filipe Manana
On Fri, Oct 23, 2015 at 4:11 PM, Jeff Mahoney wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/23/15 4:03 AM, Zhao Lei wrote: >> Since we set source bg to readonly in scrub/replace, we don't need >> to consider confliction of no-cow write in scrub/replace

Re: [PATCH] btrfs: Remove code for no-cow in scrub/replace

2015-10-23 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/23/15 4:03 AM, Zhao Lei wrote: > Since we set source bg to readonly in scrub/replace, we don't need > to consider confliction of no-cow write in scrub/replace operaion. What happens if there's a read failure? IIRC the initial purpose of this