Re: Single disk performance

2009-06-29 Thread Chris Mason
On Fri, Jun 26, 2009 at 09:26:59PM -0500, Steven Pratt wrote: Chris Mason wrote: On Fri, Jun 26, 2009 at 09:28:51AM -0500, Steven Pratt wrote: Upgraded the btrfs tree to 6-17 and all of the stability problems went away on the single disk system, so not sure if this was a code problem

[PATCH 3/5] FS: btrfs, don't touch freed memory

2009-06-29 Thread Jiri Slaby
worker memory is already freed on one fail path in btrfs_start_workers, but is still dereferenced. Switch the dereference and kfree. Signed-off-by: Jiri Slaby jirisl...@gmail.com --- fs/btrfs/async-thread.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] btrfs: 'usertrans' mount option to allow unprivileged userspace transactions

2009-06-29 Thread Sage Weil
On Fri, 26 Jun 2009, Christoph Hellwig wrote: On Thu, Jun 25, 2009 at 02:45:39PM -0700, Sage Weil wrote: This lets an administrator give non-root users access to the btrfs transaction start/end ioctls via a mount option. Currently any process using the ioctls must run as root. That's

[Patch] btrfsck.c typo?

2009-06-29 Thread TARUISI Hiroaki
Hi, Recently, I've red btrfsck.c of btrfs-progs to study the internal of btrfs. However, I may find typo in pick_next_pending() of btrfsck.c The first index of bits[] which is initialized should be 0, I think. Signed-off-by: TARUISI Hiroaki taruishi.hir...@jp.fujitsu.com --- diff --git

Redundant check in verify_parent_transid

2009-06-29 Thread TARUISI Hiroaki
Hi, In verify_parent_transid() of disk-io.c (btrfs-progs), I found redundant check. --- static int verify_parent_transid(struct extent_io_tree *io_tree, struct extent_buffer *eb, u64 parent_transid) { int ret; if (!parent_transid ||