Re: [PATCH v9 1/9] iov_iter: add copy_struct_from_iter()

2021-04-02 Thread Omar Sandoval
On Thu, Apr 01, 2021 at 09:05:22AM -0700, Linus Torvalds wrote: > On Wed, Mar 31, 2021 at 11:51 PM Omar Sandoval wrote: > > > > + * > > + * The recommended usage is something like the following: > > + * > > + * if (usize > PAGE_SIZE) > > + * return -E2BIG; > > Maybe this should be more

Re: [PATCH v3 02/10] fsdax: Factor helper: dax_fault_actor()

2021-04-02 Thread Christoph Hellwig
> + if (!pmd) > + return dax_load_hole(xas, mapping, &entry, vmf); > + else > + return dax_pmd_load_hole(xas, vmf, iomap, &entry); > + if (pmd) > + return vmf_insert_pfn_pmd(vmf, pfn, write); > + if (write) > +

Re: [PATCH v3 00/10] fsdax,xfs: Add reflink&dedupe support for fsdax

2021-04-02 Thread Christoph Hellwig
Shiyang, Dan: given that the whole reflink+dax thing is going to take a while and thus not going to happen for this merge window, what about queueing up the cleanup patches 1,2 and 3 so that we can reduce the patch load a little?

Re: [PATCH v9 1/9] iov_iter: add copy_struct_from_iter()

2021-04-02 Thread Christian Brauner
On Fri, Apr 02, 2021 at 12:33:20AM -0700, Omar Sandoval wrote: > On Thu, Apr 01, 2021 at 09:05:22AM -0700, Linus Torvalds wrote: > > On Wed, Mar 31, 2021 at 11:51 PM Omar Sandoval wrote: > > > > > > + * > > > + * The recommended usage is something like the following: > > > + * > > > + * if (us

RE: [PATCH v3 00/10] fsdax,xfs: Add reflink&dedupe support for fsdax

2021-04-02 Thread ruansy.f...@fujitsu.com
> -Original Message- > From: Christoph Hellwig > Sent: Friday, April 2, 2021 3:50 PM > Subject: Re: [PATCH v3 00/10] fsdax,xfs: Add reflink&dedupe support for fsdax > > Shiyang, Dan: > > given that the whole reflink+dax thing is going to take a while and thus not > going > to happen f

Re: [PATCH v3 00/13] btrfs: support read-write for subpage metadata

2021-04-02 Thread Ritesh Harjani
On 21/03/29 10:01AM, Qu Wenruo wrote: > > > On 2021/3/29 上午4:02, Ritesh Harjani wrote: > > On 21/03/25 09:16PM, Qu Wenruo wrote: > > > > > > > > > On 2021/3/25 下午8:20, Neal Gompa wrote: > > > > On Thu, Mar 25, 2021 at 3:17 AM Qu Wenruo wrote: > > > > > > > > > > This patchset can be fetched from t

Re: [PATCH v3 00/13] btrfs: support read-write for subpage metadata

2021-04-02 Thread Qu Wenruo
On 2021/4/2 下午4:33, Ritesh Harjani wrote: On 21/03/29 10:01AM, Qu Wenruo wrote: On 2021/3/29 上午4:02, Ritesh Harjani wrote: On 21/03/25 09:16PM, Qu Wenruo wrote: On 2021/3/25 下午8:20, Neal Gompa wrote: On Thu, Mar 25, 2021 at 3:17 AM Qu Wenruo wrote: This patchset can be fetched from

Re: [PATCH v3 00/13] btrfs: support read-write for subpage metadata

2021-04-02 Thread Ritesh Harjani
On 21/04/02 04:36PM, Qu Wenruo wrote: > > > On 2021/4/2 下午4:33, Ritesh Harjani wrote: > > On 21/03/29 10:01AM, Qu Wenruo wrote: > > > > > > > > > On 2021/3/29 上午4:02, Ritesh Harjani wrote: > > > > On 21/03/25 09:16PM, Qu Wenruo wrote: > > > > > > > > > > > > > > > On 2021/3/25 下午8:20, Neal Gompa wr

Re: [PATCH v3 00/13] btrfs: support read-write for subpage metadata

2021-04-02 Thread Qu Wenruo
On 2021/4/2 下午4:46, Ritesh Harjani wrote: On 21/04/02 04:36PM, Qu Wenruo wrote: On 2021/4/2 下午4:33, Ritesh Harjani wrote: On 21/03/29 10:01AM, Qu Wenruo wrote: On 2021/3/29 上午4:02, Ritesh Harjani wrote: On 21/03/25 09:16PM, Qu Wenruo wrote: On 2021/3/25 下午8:20, Neal Gompa wrote: On

Re: Any ideas what this warnings are about?

2021-04-02 Thread Markus Schaaf
Am 02.04.21 um 03:10 schrieb Zygo Blaxell: flushoncommit does give better crash consistency--I've been using it for years for that reason. Okay. This machine is the last I have setup, and it was my first try with flushoncommit. But I didn't remember, until you mentioned it. So I will leave i

Re: [PATCH v9 1/9] iov_iter: add copy_struct_from_iter()

2021-04-02 Thread Omar Sandoval
On Fri, Apr 02, 2021 at 10:04:23AM +0200, Christian Brauner wrote: > On Fri, Apr 02, 2021 at 12:33:20AM -0700, Omar Sandoval wrote: > > On Thu, Apr 01, 2021 at 09:05:22AM -0700, Linus Torvalds wrote: > > > On Wed, Mar 31, 2021 at 11:51 PM Omar Sandoval > > > wrote: > > > > > > > > + * > > > > + *

Re: Is request_firmware() really safe to call in resume callback when /usr/lib/firmware is on btrfs?

2021-04-02 Thread Luis Chamberlain
On Thu, Apr 01, 2021 at 04:59:47PM +0200, Lukas Middendorf wrote: > Hello Luis, > > > On 18/08/2020 16:37, Luis Chamberlain wrote: > > On Tue, Aug 18, 2020 at 12:04:51AM +0200, Lukas Middendorf wrote: > > > On 17/08/2020 17:20, Luis Chamberlain wrote: > > > > This helps, thanks so much, now we'll

Re: BTRFS error (device sda1): bdev /dev/sdb1 errs: wr 2702175, rd 2719033, flush 0, corrupt 6, gen 0

2021-04-02 Thread Thomas
Hi, I finished repartition of devices /dev/sda + /dev/sdb now. On both devices the first partition is equal in size: $ sudo fdisk -l /dev/sda Festplatte /dev/sda: 238,47 GiB, 256060514304 Bytes, 500118192 Sektoren Festplattenmodell: SanDisk SD8SBAT2 Einheiten: Sektoren von 1 * 512 = 512 Bytes Sekt

Re: Is request_firmware() really safe to call in resume callback when /usr/lib/firmware is on btrfs?

2021-04-02 Thread Luis Chamberlain
Lukas, can you share your /etc/fstab ? Also, how long do you stay in the boot before you try to suspend? Luis

Autodefrag with nocow Attribute

2021-04-02 Thread Jonah Sabean
My understanding is btrfs will perform poorly with use cases such as large databases that have a large amount of random reads/writes. As such, the nocow attribute is usually suggested to allow overwriting to help reduce fragmentation that would otherwise occur (bearing in mind the downsides of usin

Re: Is request_firmware() really safe to call in resume callback when /usr/lib/firmware is on btrfs?

2021-04-02 Thread Luis Chamberlain
On Fri, Apr 2, 2021 at 3:19 PM Luis Chamberlain wrote: > > Lukas, can you share your /etc/fstab ? Also, how long do you stay in > the boot before you try to suspend? OK I cannot reproduce the issue with the modified patch I sent to test_firmware, which if you enable config_enable_resume_test will