Re: [PATCH v2] btrfs: fix lockdep warning while mounting sprout fs

2021-04-05 Thread Anand Jain
Ping again. Thanks, Anand On 06/03/2021 16:37, Anand Jain wrote: David, Ping? Thanks, Anand On 04/03/2021 02:10, Anand Jain wrote: Following test case reproduces lockdep warning. Test case: DEV1=/dev/vdb DEV2=/dev/vdc umount /btrfs run mkfs.btrfs -f $DEV1 run btrfstune -S 1 $DEV1 run mou

Re: [PATCH v2] btrfs: fix lockdep warning while mounting sprout fs

2021-04-05 Thread Su Yue
On Mon 05 Apr 2021 at 16:38, Anand Jain wrote: Ping again. It's already queued in misc-next. commit 441737bb30f83914bb8517f52088c0130138d74b (misc-next) Author: Anand Jain Date: Fri Jul 17 18:05:25 2020 +0800 btrfs: fix lockdep warning while mounting sprout fs Martin reported

Re: [PATCH v2] btrfs: fix lockdep warning while mounting sprout fs

2021-04-05 Thread Anand Jain
On 05/04/2021 17:18, Su Yue wrote: On Mon 05 Apr 2021 at 16:38, Anand Jain wrote: Ping again. It's already queued in misc-next. Oh thanks. Thanks David. -Anand commit 441737bb30f83914bb8517f52088c0130138d74b (misc-next) Author: Anand Jain Date:   Fri Jul 17 18:05:25 2020 +0800

Re: Is request_firmware() really safe to call in resume callback when /usr/lib/firmware is on btrfs?

2021-04-05 Thread Lukas Middendorf
On 03/04/2021 23:04, Luis Chamberlain wrote: OK this fixes it but this just shows that likely the thaw'ing allows a race to take place which we didn't expect. I'll do some more digging for a proper fix. I can indeed confirm that this fixes the stall. This however does not seem to be the (com

[PATCH -next] btrfs: integrity-checker: use DEFINE_MUTEX() for mutex lock

2021-04-05 Thread Zheng Yongjun
mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init(). Reported-by: Hulk Robot Signed-off-by: Zheng Yongjun --- fs/btrfs/check-integrity.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/btrfs/check-integrity.c b/fs/

Re: kernel BUG at fs/btrfs/tree-mod-log.c:675 - misc-next 9228ad80f849 (Mar 29 2021)

2021-04-05 Thread Filipe Manana
On Sun, Apr 4, 2021 at 5:16 AM Zygo Blaxell wrote: > > Base kernel is 9228ad80f849 "btrfs: zoned: move log tree node allocation > out of log_root_tree->log_mutex" from misc-next on 2021-03-29. > > The BUG() moved, but we are still hitting it: > > [145427.426011][ T5492] BTRFS info (device

[PATCH] btrfs: fix race between transaction aborts and fsyncs leading to use-after-free

2021-04-05 Thread fdmanana
From: Filipe Manana There is a race between a task aborting a transaction during a commit, a task doing an fsync and the transaction kthread, which leads to an use-after-free of the log root tree. When this happens, it results in a stack trace like the following: [99678.547335] BTRFS info (devic

Device missing with RAID1 on boot - observations

2021-04-05 Thread Steven Davies
Kernel: 5.11.8 vanilla, btrfs-progs 5.11.1 I booted a box with a root btrfs raid1 across two devices, /dev/nvme0n1p2 (devid 2) and /dev/sda2 (devid 3). For whatever reason during the initrd stage, btrfs device scan was unable to see the NVMe device and mounted the rootfs degraded after multiple

HI,

2021-04-05 Thread Vanina curt
How are you? I'm Vanina. I picked interest in you and I would like to know more about you and establish relationship with you. i will wait for your response. thank you.

Re: Device missing with RAID1 on boot - observations

2021-04-05 Thread Qu Wenruo
On 2021/4/5 下午11:18, Steven Davies wrote: Kernel: 5.11.8 vanilla, btrfs-progs 5.11.1 I booted a box with a root btrfs raid1 across two devices, /dev/nvme0n1p2 (devid 2) and /dev/sda2 (devid 3). For whatever reason during the initrd stage, btrfs device scan was unable to see the NVMe device an

[PATCH 0/4] btrfs: the missing 4 patches to implement metadata write path

2021-04-05 Thread Qu Wenruo
When adding the comments for subpage metadata code, I inserted the comment patch into the wrong position, and then use that patch as a separator between data and metadata write path. Thus the submitted metadata write path patchset lacks the real functions to submit subpage metadata write bio. Qu

[PATCH 1/4] btrfs: introduce end_bio_subpage_eb_writepage() function

2021-04-05 Thread Qu Wenruo
The new function, end_bio_subpage_eb_writepage(), will handle the metadata writeback endio. The major differences involved are: - How to grab extent buffer Now page::private is a pointer to btrfs_subpage, we can no longer grab extent buffer directly. Thus we need to use the bv_offset to loca

[PATCH 2/4] btrfs: introduce write_one_subpage_eb() function

2021-04-05 Thread Qu Wenruo
The new function, write_one_subpage_eb(), as a subroutine for subpage metadata write, will handle the extent buffer bio submission. The major differences between the new write_one_subpage_eb() and write_one_eb() is: - No page locking When entering write_one_subpage_eb() the page is no longer loc

[PATCH 3/4] btrfs: make lock_extent_buffer_for_io() to be subpage compatible

2021-04-05 Thread Qu Wenruo
For subpage metadata, we don't use page locking at all. So just skip the page locking part for subpage. All the remaining routine can be reused. Signed-off-by: Qu Wenruo --- fs/btrfs/extent_io.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/extent_io.c b/fs

[PATCH 4/4] btrfs: introduce submit_eb_subpage() to submit a subpage metadata page

2021-04-05 Thread Qu Wenruo
The new function, submit_eb_subpage(), will submit all the dirty extent buffers in the page. The major difference between submit_eb_page() and submit_eb_subpage() is: - How to grab extent buffer Now we use find_extent_buffer_nospinlock() other than using page::private. All other different han

Re: [PATCH v3 00/13] btrfs: support read-write for subpage metadata

2021-04-05 Thread Anand Jain
On 05/04/2021 14:14, Qu Wenruo wrote: On 2021/4/3 下午7:08, David Sterba wrote: On Thu, Mar 25, 2021 at 03:14:32PM +0800, Qu Wenruo wrote: This patchset can be fetched from the following github repo, along with the full subpage RW support: https://github.com/adam900710/linux/tree/subpage This