Re: [PATCH] btrfs: fix describe_relocation string pointer
On Thu, May 17, 2018 at 09:25:12PM +0800, Anand Jain wrote: > Looks like the original idea was to print the hex of the flags which > is not coded with their flag name. So use the current buf pointer bp > instead of buf. > > Signed-off-by: Anand Jain > --- > fs/btrfs/relocation.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c > index 74656d79e511..879b76fa881a 100644 > --- a/fs/btrfs/relocation.c > +++ b/fs/btrfs/relocation.c > @@ -4344,7 +4344,7 @@ static void describe_relocation(struct btrfs_fs_info > *fs_info, > DESCRIBE_FLAG(RAID5,"raid5"); > DESCRIBE_FLAG(RAID6,"raid6"); > if (flags) > - snprintf(buf, buf - bp + sizeof(buf), "|0x%llx", flags); > + snprintf(bp, buf - bp + sizeof(buf), "|0x%llx", flags); Good catch. Reviewed-by: David Sterba -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] btrfs: fix describe_relocation string pointer
Looks like the original idea was to print the hex of the flags which is not coded with their flag name. So use the current buf pointer bp instead of buf. Signed-off-by: Anand Jain --- fs/btrfs/relocation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index 74656d79e511..879b76fa881a 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -4344,7 +4344,7 @@ static void describe_relocation(struct btrfs_fs_info *fs_info, DESCRIBE_FLAG(RAID5,"raid5"); DESCRIBE_FLAG(RAID6,"raid6"); if (flags) - snprintf(buf, buf - bp + sizeof(buf), "|0x%llx", flags); + snprintf(bp, buf - bp + sizeof(buf), "|0x%llx", flags); #undef DESCRIBE_FLAG } -- 2.15.0 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
