Re: [PATCH] fstests: btrfs: Add test for corrupted orphan qgroup numbers

2018-08-10 Thread Qu Wenruo
On 8/10/18 5:42 PM, Eryu Guan wrote: > On Fri, Aug 10, 2018 at 05:10:29PM +0800, Qu Wenruo wrote: >> >> >> On 8/10/18 4:54 PM, Filipe Manana wrote: >>> On Fri, Aug 10, 2018 at 9:46 AM, Qu Wenruo wrote: On 8/9/18 5:26 PM, Filipe Manana wrote: > On Thu, Aug 9, 2018 at 8:45 AM,

Re: [PATCH] fstests: btrfs: Add test for corrupted orphan qgroup numbers

2018-08-10 Thread Eryu Guan
On Fri, Aug 10, 2018 at 05:10:29PM +0800, Qu Wenruo wrote: > > > On 8/10/18 4:54 PM, Filipe Manana wrote: > > On Fri, Aug 10, 2018 at 9:46 AM, Qu Wenruo wrote: > >> > >> > >> On 8/9/18 5:26 PM, Filipe Manana wrote: > >>> On Thu, Aug 9, 2018 at 8:45 AM, Qu Wenruo wrote: > This bug is

Re: [PATCH] fstests: btrfs: Add test for corrupted orphan qgroup numbers

2018-08-10 Thread Qu Wenruo
On 8/10/18 4:54 PM, Filipe Manana wrote: > On Fri, Aug 10, 2018 at 9:46 AM, Qu Wenruo wrote: >> >> >> On 8/9/18 5:26 PM, Filipe Manana wrote: >>> On Thu, Aug 9, 2018 at 8:45 AM, Qu Wenruo wrote: This bug is exposed by populating a high level qgroup, and then make it orphan (high

Re: [PATCH] fstests: btrfs: Add test for corrupted orphan qgroup numbers

2018-08-10 Thread Filipe Manana
On Fri, Aug 10, 2018 at 9:46 AM, Qu Wenruo wrote: > > > On 8/9/18 5:26 PM, Filipe Manana wrote: >> On Thu, Aug 9, 2018 at 8:45 AM, Qu Wenruo wrote: >>> This bug is exposed by populating a high level qgroup, and then make it >>> orphan (high level qgroup without child) >> >> Same comment as in

Re: [PATCH] fstests: btrfs: Add test for corrupted orphan qgroup numbers

2018-08-10 Thread Qu Wenruo
On 8/9/18 5:26 PM, Filipe Manana wrote: > On Thu, Aug 9, 2018 at 8:45 AM, Qu Wenruo wrote: >> This bug is exposed by populating a high level qgroup, and then make it >> orphan (high level qgroup without child) > > Same comment as in the kernel patch: > > "That sentence is confusing. An

Re: [PATCH] fstests: btrfs: Add test for corrupted orphan qgroup numbers

2018-08-09 Thread Filipe Manana
On Thu, Aug 9, 2018 at 8:45 AM, Qu Wenruo wrote: > This bug is exposed by populating a high level qgroup, and then make it > orphan (high level qgroup without child) Same comment as in the kernel patch: "That sentence is confusing. An orphan, by definition [1], is someone (or something in this

[PATCH] fstests: btrfs: Add test for corrupted orphan qgroup numbers

2018-08-09 Thread Qu Wenruo
This bug is exposed by populating a high level qgroup, and then make it orphan (high level qgroup without child) with old qgroup numbers, and finally do rescan. Normally rescan should zero out all qgroups' accounting number, but due to a kernel bug which won't mark orphan qgroups dirty, their