Re: [PATCH 2/3] btrfs-progs: send: fix handling of multiple snapshots (-p option)

2016-11-15 Thread Tsutomu Itoh
xfstests btrfs/038 fails when this patch is applied. Sorry for my fault. I posted the patch that corrected this problem. [PATCH] btrfs-progs: send: fix failure of xfstests btrfs/038 Thanks, Tsutomu On 2016/10/19 11:35, Tsutomu Itoh wrote: > We cannot send multiple snapshots at once by -p

Re: [PATCH 2/3] btrfs-progs: send: fix handling of multiple snapshots (-p option)

2016-11-02 Thread David Sterba
On Wed, Nov 02, 2016 at 10:11:55AM +0900, Tsutomu Itoh wrote: > > I'm not sure it's fixed, I wrote a simple test, attached, that triggers > > the bug even with the patch applied. > > In the attached script, > >run_check $SUDO_HELPER btrfs send -f "$here"/send.stream -p subv-snap1 >

Re: [PATCH 2/3] btrfs-progs: send: fix handling of multiple snapshots (-p option)

2016-11-01 Thread Tsutomu Itoh
Sorry for the late reply. On 2016/10/29 0:10, David Sterba wrote: > On Wed, Oct 19, 2016 at 11:35:03AM +0900, Tsutomu Itoh wrote: >> We cannot send multiple snapshots at once by -p option. > > We cannot like that it's broken, or we cannot because it's not supposed > to work that way. I guess

Re: [PATCH 2/3] btrfs-progs: send: fix handling of multiple snapshots (-p option)

2016-10-28 Thread David Sterba
On Wed, Oct 19, 2016 at 11:35:03AM +0900, Tsutomu Itoh wrote: > We cannot send multiple snapshots at once by -p option. We cannot like that it's broken, or we cannot because it's not supposed to work that way. I guess it's the former, but the changelog text is a bit confusing. > > [before] > #

[PATCH 2/3] btrfs-progs: send: fix handling of multiple snapshots (-p option)

2016-10-18 Thread Tsutomu Itoh
We cannot send multiple snapshots at once by -p option. [before] # btrfs send -f /tmp/data0 -p Snap0 Snap[12] At subvol Snap1 At subvol Snap2 ERROR: parent determination failed for 0 # [after] # btrfs send -f /tmp/data0 -p Snap0 Snap[12] At subvol Snap1 At subvol Snap2 # Signed-off-by: