Re: [PATCH v2 4/6] Btrfs: remove unused check of skip_locking

2018-05-28 Thread Nikolay Borisov
On 28.05.2018 17:21, David Sterba wrote: > On Fri, May 18, 2018 at 01:27:50PM +0800, Qu Wenruo wrote: >> >> >> On 2018年05月18日 11:00, Liu Bo wrote: >>> The check is superfluous since all of callers who set search_for_commit >>> also have skip_locking set. >>> >>> Signed-off-by: Liu Bo

Re: [PATCH v2 4/6] Btrfs: remove unused check of skip_locking

2018-05-28 Thread David Sterba
On Fri, May 18, 2018 at 01:27:50PM +0800, Qu Wenruo wrote: > > > On 2018年05月18日 11:00, Liu Bo wrote: > > The check is superfluous since all of callers who set search_for_commit > > also have skip_locking set. > > > > Signed-off-by: Liu Bo > > Reviewed-by: Qu Wenruo

Re: [PATCH v2 4/6] Btrfs: remove unused check of skip_locking

2018-05-17 Thread Qu Wenruo
On 2018年05月18日 11:00, Liu Bo wrote: > The check is superfluous since all of callers who set search_for_commit > also have skip_locking set. > > Signed-off-by: Liu Bo Reviewed-by: Qu Wenruo Although more obvious comment about search_commit_root and

[PATCH v2 4/6] Btrfs: remove unused check of skip_locking

2018-05-17 Thread Liu Bo
The check is superfluous since all of callers who set search_for_commit also have skip_locking set. Signed-off-by: Liu Bo --- fs/btrfs/ctree.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index d12fc0474e21..8d3b09038f37