Re: [PATCH v6 9/9] tmpfs: add support for multigrain timestamps

2024-07-17 Thread Jan Kara
On Mon 15-07-24 08:49:00, Jeff Layton wrote:
> Enable multigrain timestamps, which should ensure that there is an
> apparent change to the timestamp whenever it has been written after
> being actively observed via getattr.
> 
> tmpfs only requires the FS_MGTIME flag.
> 
> Reviewed-by: Josef Bacik 
> Signed-off-by: Jeff Layton 

Looks good to me. Feel free to add:

Reviewed-by: Jan Kara 

Honza

> ---
>  mm/shmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 7f2b609945a5..75a9a73a769f 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -4660,7 +4660,7 @@ static struct file_system_type shmem_fs_type = {
>   .parameters = shmem_fs_parameters,
>  #endif
>   .kill_sb= kill_litter_super,
> - .fs_flags   = FS_USERNS_MOUNT | FS_ALLOW_IDMAP,
> + .fs_flags   = FS_USERNS_MOUNT | FS_ALLOW_IDMAP | FS_MGTIME,
>  };
>  
>  void __init shmem_init(void)
> 
> -- 
> 2.45.2
> 
-- 
Jan Kara 
SUSE Labs, CR



[PATCH v6 9/9] tmpfs: add support for multigrain timestamps

2024-07-15 Thread Jeff Layton
Enable multigrain timestamps, which should ensure that there is an
apparent change to the timestamp whenever it has been written after
being actively observed via getattr.

tmpfs only requires the FS_MGTIME flag.

Reviewed-by: Josef Bacik 
Signed-off-by: Jeff Layton 
---
 mm/shmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 7f2b609945a5..75a9a73a769f 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -4660,7 +4660,7 @@ static struct file_system_type shmem_fs_type = {
.parameters = shmem_fs_parameters,
 #endif
.kill_sb= kill_litter_super,
-   .fs_flags   = FS_USERNS_MOUNT | FS_ALLOW_IDMAP,
+   .fs_flags   = FS_USERNS_MOUNT | FS_ALLOW_IDMAP | FS_MGTIME,
 };
 
 void __init shmem_init(void)

-- 
2.45.2