Re: [PATCH] Btrfs: add discard flag to btrfs_device and make btrfs_discard_extent aware of that

2011-06-13 Thread David Sterba
On Fri, Jun 10, 2011 at 01:40:31PM +0800, Li Dongyang wrote: otherwise the patch looks good (and matches my view how to do it). I will test it eventually. Thanks a lot, I'll resend this this a proper name. JFYI, tested in the previous scenario, ie. all devices without trim support, does not

Re: [PATCH] Btrfs: add discard flag to btrfs_device and make btrfs_discard_extent aware of that

2011-06-09 Thread David Sterba
On Thu, Jun 09, 2011 at 03:28:09PM +0800, Li Dongyang wrote: --- a/fs/btrfs/volumes.h +++ b/fs/btrfs/volumes.h @@ -45,6 +45,7 @@ struct btrfs_device { int running_pending; u64 generation; + int discard; can you pick a better name? this does not describe that it's the

Re: [PATCH] Btrfs: add discard flag to btrfs_device and make btrfs_discard_extent aware of that

2011-06-09 Thread Li Dongyang
On Friday, June 10, 2011 08:00:17 AM David Sterba wrote: On Thu, Jun 09, 2011 at 03:28:09PM +0800, Li Dongyang wrote: --- a/fs/btrfs/volumes.h +++ b/fs/btrfs/volumes.h @@ -45,6 +45,7 @@ struct btrfs_device { int running_pending; u64 generation; + int discard; can you