Re: [PATCH] Btrfs: add file item tracepoint
On Thu, Mar 09, 2017 at 01:52:22PM +0100, David Sterba wrote: > On Tue, Mar 07, 2017 at 08:49:42AM -0800, Liu Bo wrote: > > On Tue, Mar 07, 2017 at 04:48:24PM +0100, David Sterba wrote: > > > On Fri, Mar 03, 2017 at 06:41:27PM -0800, Liu Bo wrote: > > > > + TP_printk_btrfs( > > > > + "root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx " > > > > + "file extent range [0x%llx 0x%llx] " > > > > + "(num_bytes 0x%llx ram_bytes 0x%llx disk_bytenr 0x%llx " > > > > + "disk_num_bytes 0x%llx extent_offset 0x%llx type (%s) " > > > > + "compression %u", > > > > > > > + TP_printk_btrfs( > > > > + "root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx " > > > > + "file extent range [0x%llx 0x%llx] " > > > > + "extent_type (%s) compression %u", > > > > > > Please update the message formats according to > > > https://btrfs.wiki.kernel.org/index.php/Development_notes#Tracepoints > > > > I feel like for size and offset, if using '%llu' rather than '%llx', it > > is not easy to tell whether the size/offset is aligned to 4K or not. > > I think we'll have to do some conversion either way, and I don't see > %llx used anywhere in our thacepoints. > > If the alignment is useful for certain values, we can extend the format > to signify that, for example: "start=4097!". OK, I'll update this patch to comply with the wiki so you can take it, and then make a new patch to convert %llu to %llx to see if any objections. Thanks, -liubo -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Btrfs: add file item tracepoint
On Tue, Mar 07, 2017 at 08:49:42AM -0800, Liu Bo wrote: > On Tue, Mar 07, 2017 at 04:48:24PM +0100, David Sterba wrote: > > On Fri, Mar 03, 2017 at 06:41:27PM -0800, Liu Bo wrote: > > > + TP_printk_btrfs( > > > + "root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx " > > > + "file extent range [0x%llx 0x%llx] " > > > + "(num_bytes 0x%llx ram_bytes 0x%llx disk_bytenr 0x%llx " > > > + "disk_num_bytes 0x%llx extent_offset 0x%llx type (%s) " > > > + "compression %u", > > > > > + TP_printk_btrfs( > > > + "root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx " > > > + "file extent range [0x%llx 0x%llx] " > > > + "extent_type (%s) compression %u", > > > > Please update the message formats according to > > https://btrfs.wiki.kernel.org/index.php/Development_notes#Tracepoints > > I feel like for size and offset, if using '%llu' rather than '%llx', it > is not easy to tell whether the size/offset is aligned to 4K or not. I think we'll have to do some conversion either way, and I don't see %llx used anywhere in our thacepoints. If the alignment is useful for certain values, we can extend the format to signify that, for example: "start=4097!". -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Btrfs: add file item tracepoint
On Tue, Mar 07, 2017 at 04:48:24PM +0100, David Sterba wrote: > On Fri, Mar 03, 2017 at 06:41:27PM -0800, Liu Bo wrote: > > + TP_printk_btrfs( > > + "root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx " > > + "file extent range [0x%llx 0x%llx] " > > + "(num_bytes 0x%llx ram_bytes 0x%llx disk_bytenr 0x%llx " > > + "disk_num_bytes 0x%llx extent_offset 0x%llx type (%s) " > > + "compression %u", > > > + TP_printk_btrfs( > > + "root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx " > > + "file extent range [0x%llx 0x%llx] " > > + "extent_type (%s) compression %u", > > Please update the message formats according to > https://btrfs.wiki.kernel.org/index.php/Development_notes#Tracepoints I feel like for size and offset, if using '%llu' rather than '%llx', it is not easy to tell whether the size/offset is aligned to 4K or not. Thanks, -liubo -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Btrfs: add file item tracepoint
On Fri, Mar 03, 2017 at 06:41:27PM -0800, Liu Bo wrote: > + TP_printk_btrfs( > + "root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx " > + "file extent range [0x%llx 0x%llx] " > + "(num_bytes 0x%llx ram_bytes 0x%llx disk_bytenr 0x%llx " > + "disk_num_bytes 0x%llx extent_offset 0x%llx type (%s) " > + "compression %u", > + TP_printk_btrfs( > + "root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx " > + "file extent range [0x%llx 0x%llx] " > + "extent_type (%s) compression %u", Please update the message formats according to https://btrfs.wiki.kernel.org/index.php/Development_notes#Tracepoints -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
