Re: [PATCH] Btrfs: fix all callers of read_tree_block

2013-07-30 Thread Alex Lyakas
Hi Josef, On Tue, Apr 23, 2013 at 9:20 PM, Josef Bacik jba...@fusionio.com wrote: We kept leaking extent buffers when mounting a broken file system and it turns out it's because not everybody uses read_tree_block properly. You need to check and make sure the extent_buffer is uptodate before

Re: [PATCH] Btrfs: fix all callers of read_tree_block

2013-07-30 Thread Josef Bacik
On Tue, Jul 30, 2013 at 06:11:39PM +0300, Alex Lyakas wrote: Hi Josef, On Tue, Apr 23, 2013 at 9:20 PM, Josef Bacik jba...@fusionio.com wrote: We kept leaking extent buffers when mounting a broken file system and it turns out it's because not everybody uses read_tree_block properly.

Re: [PATCH] Btrfs: fix all callers of read_tree_block

2013-04-24 Thread Liu Bo
On Tue, Apr 23, 2013 at 02:20:22PM -0400, Josef Bacik wrote: We kept leaking extent buffers when mounting a broken file system and it turns out it's because not everybody uses read_tree_block properly. You need to check and make sure the extent_buffer is uptodate before you use it. This

Re: [PATCH] Btrfs: fix all callers of read_tree_block

2013-04-24 Thread Josef Bacik
On Wed, Apr 24, 2013 at 02:17:48AM -0600, Liu Bo wrote: On Tue, Apr 23, 2013 at 02:20:22PM -0400, Josef Bacik wrote: We kept leaking extent buffers when mounting a broken file system and it turns out it's because not everybody uses read_tree_block properly. You need to check and make

Re: [PATCH] Btrfs: fix all callers of read_tree_block

2013-04-24 Thread David Sterba
On Tue, Apr 23, 2013 at 02:20:22PM -0400, Josef Bacik wrote: We kept leaking extent buffers when mounting a broken file system and it turns out it's because not everybody uses read_tree_block properly. You need to check and make sure the extent_buffer is uptodate before you use it. This