Re: [PATCH] btrfs: change btrfs_csum_final result param type to u8
On 2016-10-12 16:43 +0200, David Sterba wrote: > On Mon, Sep 19, 2016 at 07:22:28PM +0200, David Sterba wrote: > > On Sun, Sep 18, 2016 at 12:10:34AM +0100, Domagoj Tršan wrote: > > > csum member of struct btrfs_super_block has array type of u8. It makes > > > sense > > > that function btrfs_csum_final should be also declared to accept u8 *. I > > > changed the declaration of method void btrfs_csum_final(u32 crc, char > > > *result); > > > to void btrfs_csum_final(u32 crc, u8 *result); > > > > You should put a similar text to the patch itself, it's not necessary to > > send the cover letter for single patches. Otherwise the change is ok. > > Please update the patch according to the above and resend. Hi David, apologies for the delay. I sent the new version patch. Cheers! -- (\/)(;,,;)(\/) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] btrfs: change btrfs_csum_final result param type to u8
On Mon, Sep 19, 2016 at 07:22:28PM +0200, David Sterba wrote: > On Sun, Sep 18, 2016 at 12:10:34AM +0100, Domagoj Tršan wrote: > > csum member of struct btrfs_super_block has array type of u8. It makes sense > > that function btrfs_csum_final should be also declared to accept u8 *. I > > changed the declaration of method void btrfs_csum_final(u32 crc, char > > *result); > > to void btrfs_csum_final(u32 crc, u8 *result); > > You should put a similar text to the patch itself, it's not necessary to > send the cover letter for single patches. Otherwise the change is ok. Please update the patch according to the above and resend. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] btrfs: change btrfs_csum_final result param type to u8
On Sun, Sep 18, 2016 at 12:10:34AM +0100, Domagoj Tršan wrote: > csum member of struct btrfs_super_block has array type of u8. It makes sense > that function btrfs_csum_final should be also declared to accept u8 *. I > changed the declaration of method void btrfs_csum_final(u32 crc, char > *result); > to void btrfs_csum_final(u32 crc, u8 *result); You should put a similar text to the patch itself, it's not necessary to send the cover letter for single patches. Otherwise the change is ok. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
