Re: [PATCH] btrfs: fix double-free 'tree_root' in 'btrfs_mount()'

2011-11-07 Thread Christoph Hellwig
On Mon, Nov 07, 2011 at 12:12:07PM +0300, sly...@gmail.com wrote:
 bdev=/dev/ubda
 btr_root=/btr
 /mkfs.btrfs $bdev
 mount $bdev $btr_root
 mkdir $btr_root/subvols/
 cd $btr_root/subvols/
 /btrfs su cr foo
 /btrfs su cr bar
 mount $bdev -osubvol=subvols/foo $btr_root/subvols/bar
 umount $btr_root/subvols/bar

Can you please send this as a new testcase for xfstests?

--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] btrfs: fix double-free 'tree_root' in 'btrfs_mount()'

2011-11-07 Thread Sergei Trofimovich
  bdev=/dev/ubda
  btr_root=/btr
  /mkfs.btrfs $bdev
  mount $bdev $btr_root
  mkdir $btr_root/subvols/
  cd $btr_root/subvols/
  /btrfs su cr foo
  /btrfs su cr bar
  mount $bdev -osubvol=subvols/foo $btr_root/subvols/bar
  umount $btr_root/subvols/bar
 
 Can you please send this as a new testcase for xfstests?

I'll try to. Will take some time though (never seen it before).
Thanks!

-- 

  Sergei


signature.asc
Description: PGP signature


Re: [PATCH] btrfs: fix double-free 'tree_root' in 'btrfs_mount()'

2011-11-07 Thread Chris Mason
On Mon, Nov 07, 2011 at 12:12:07PM +0300, sly...@gmail.com wrote:
 From: Sergei Trofimovich sly...@gentoo.org
 
 On error path 'tree_root' is treed in 'free_fs_info()'.
 No need to free it explicitely. Noticed by SLUB in debug mode:

Nice, thanks for the patch.

-chris
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html