Re: [PATCH] btrfs-progs: let mkfs return nozero value on thin provision device

2018-04-09 Thread David Sterba
On Mon, Apr 09, 2018 at 11:46:32PM +0800, Damenly Su wrote: > Sorry for the previous reply in HTML format which is not delivered to > the mail list. > > I mean there is already xfstests generic/405 for the situation. > Thin provision devices need to call dmsetup to setup. > I wonder If calling

Re: [PATCH] btrfs-progs: let mkfs return nozero value on thin provision device

2018-04-09 Thread Damenly Su
Sorry for the previous reply in HTML format which is not delivered to the mail list. I mean there is already xfstests generic/405 for the situation. Thin provision devices need to call dmsetup to setup. I wonder If calling dmsetup in progs tests is acceptable or not. If it is, I will do it.

Re: [PATCH] btrfs-progs: let mkfs return nozero value on thin provision device

2018-04-09 Thread David Sterba
On Tue, Apr 03, 2018 at 04:39:45PM +0800, Su Yue wrote: > when mkfs.btrfs on a thin provision device which has very small > backing size and big virtual size, all code works well in > mkfs.btrfs until close_ctree() is called. > close_ctree() fails to sync device due to small backing size > while

Re: [PATCH] btrfs-progs: let mkfs return nozero value on thin provision device

2018-04-03 Thread Qu Wenruo
On 2018年04月03日 16:39, Su Yue wrote: > when mkfs.btrfs on a thin provision device which has very small > backing size and big virtual size, all code works well in > mkfs.btrfs until close_ctree() is called. > close_ctree() fails to sync device due to small backing size > while closing devices. >