Re: [PATCH]btrfs-progs: Add fast,slow symlinks and fifo types to convert test

2016-09-20 Thread lakshmipathi . g

On 2016-09-19 18:21, Qu Wenruo wrote:

Just curious, did the new fifo/slow_symlink exposed any convert bug?

Thanks,
Qu
Unfortunately no. I was hoping something will fail, but sadly 
convert-tests.sh passed!

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH]btrfs-progs: Add fast,slow symlinks and fifo types to convert test

2016-09-20 Thread lakshmipathi . g

On 2016-09-19 11:05, David Sterba wrote:

On Thu, Sep 15, 2016 at 11:34:07AM +0200, Lakshmipathi.G wrote:

+   slow_symlink)
+   for num in $(seq 1 $DATASET_SIZE); do
+   fname64=`date +%s | sha256sum | cut -f1 -d'-'`


Do you need to generate the date and sha all the time?



Right, I missed that part. We can create a single file and create 
multiple symlink to that same file. fname64 creation can be moved out of 
the loop. I'll re-send another patch with this fix.



Cheers.
Lakshmipathi.G
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH]btrfs-progs: Add fast,slow symlinks and fifo types to convert test

2016-09-19 Thread David Sterba
On Thu, Sep 15, 2016 at 11:34:07AM +0200, Lakshmipathi.G wrote:
> + slow_symlink)
> + for num in $(seq 1 $DATASET_SIZE); do
> + fname64=`date +%s | sha256sum | cut -f1 -d'-'`

Do you need to generate the date and sha all the time?

> + run_check $SUDO_HELPER touch $dirpath/$fname64
> + run_check $SUDO_HELPER ln -s $dirpath/$fname64 
> $dirpath/slow_slink.$num
> + done
> + ;;
>   esac
>  }
>  
>  populate_fs() {
>  
> -for dataset_type in 'small' 'hardlink' 'symlink' 'brokenlink' 'perm' 
> 'sparse' 'acls'; do
> +for dataset_type in 'small' 'hardlink' 'fast_symlink' 'brokenlink' 
> 'perm' 'sparse' 'acls' 'fifo' 'slow_symlink'; do
>   generate_dataset "$dataset_type"
>   done
>  }
> -- 
> 1.9.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html