Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-07-01 Thread Josef Bacik
On Tue, Jun 04, 2013 at 06:17:54PM -0400, Zach Brown wrote: Hi gang, I finally sat down to fix that readdir hang that has been in the back of my mind for a while. I *hope* that the fix is pretty simple: just don't manufacture a fake f_pos, I *think* we can abuse f_version as an indicator

Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-07-01 Thread Chris Mason
Quoting Josef Bacik (2013-07-01 08:54:35) On Tue, Jun 04, 2013 at 06:17:54PM -0400, Zach Brown wrote: Hi gang, I finally sat down to fix that readdir hang that has been in the back of my mind for a while. I *hope* that the fix is pretty simple: just don't manufacture a fake f_pos, I

Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-07-01 Thread Zach Brown
code. It's all lightly tested with xfstests but it wouldn't surprise me if I missed something so review is appreciated. *mmm, hmmm* One of these patches is making new entries not show up in readdir. This was discovered while running stress.sh overnight, it complained about files not

Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-06-12 Thread Chris Mason
Quoting Zach Brown (2013-06-10 18:39:58) On Tue, Jun 04, 2013 at 04:26:57PM -0700, Zach Brown wrote: On Tue, Jun 04, 2013 at 07:16:53PM -0400, Chris Mason wrote: Quoting Zach Brown (2013-06-04 18:17:54) Hi gang, I finally sat down to fix that readdir hang that has been in the

Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-06-10 Thread Zach Brown
On Tue, Jun 04, 2013 at 04:26:57PM -0700, Zach Brown wrote: On Tue, Jun 04, 2013 at 07:16:53PM -0400, Chris Mason wrote: Quoting Zach Brown (2013-06-04 18:17:54) Hi gang, I finally sat down to fix that readdir hang that has been in the back of my mind for a while. I *hope* that

Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-06-06 Thread David Sterba
On Thu, Jun 06, 2013 at 09:35:07AM +0800, Miao Xie wrote: Onwed, 5 Jun 2013 15:36:36 +0200, David Sterba wrote: On Wed, Jun 05, 2013 at 10:34:08AM +0800, Miao Xie wrote: On tue, 4 Jun 2013 16:26:57 -0700, Zach Brown wrote: On Tue, Jun 04, 2013 at 07:16:53PM -0400, Chris Mason

Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-06-06 Thread Chris Mason
Quoting David Sterba (2013-06-06 09:55:50) On Thu, Jun 06, 2013 at 09:35:07AM +0800, Miao Xie wrote: Onwed, 5 Jun 2013 15:36:36 +0200, David Sterba wrote: On Wed, Jun 05, 2013 at 10:34:08AM +0800, Miao Xie wrote: On tue, 4 Jun 2013 16:26:57 -0700, Zach Brown wrote: On Tue,

Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-06-05 Thread David Sterba
On Wed, Jun 05, 2013 at 10:34:08AM +0800, Miao Xie wrote: Ontue, 4 Jun 2013 16:26:57 -0700, Zach Brown wrote: On Tue, Jun 04, 2013 at 07:16:53PM -0400, Chris Mason wrote: Quoting Zach Brown (2013-06-04 18:17:54) Hi gang, I finally sat down to fix that readdir hang that has been in

Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-06-05 Thread Miao Xie
On wed, 5 Jun 2013 15:36:36 +0200, David Sterba wrote: On Wed, Jun 05, 2013 at 10:34:08AM +0800, Miao Xie wrote: On tue, 4 Jun 2013 16:26:57 -0700, Zach Brown wrote: On Tue, Jun 04, 2013 at 07:16:53PM -0400, Chris Mason wrote: Quoting Zach Brown (2013-06-04 18:17:54) Hi gang, I

Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-06-04 Thread Chris Mason
Quoting Zach Brown (2013-06-04 18:17:54) Hi gang, I finally sat down to fix that readdir hang that has been in the back of my mind for a while. I *hope* that the fix is pretty simple: just don't manufacture a fake f_pos, I *think* we can abuse f_version as an indicator that we shouldn't

Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-06-04 Thread Zach Brown
On Tue, Jun 04, 2013 at 07:16:53PM -0400, Chris Mason wrote: Quoting Zach Brown (2013-06-04 18:17:54) Hi gang, I finally sat down to fix that readdir hang that has been in the back of my mind for a while. I *hope* that the fix is pretty simple: just don't manufacture a fake f_pos, I

Re: [PATCH 0/6] fix INT_MAX readdir hang, plus cleanups

2013-06-04 Thread Miao Xie
On tue, 4 Jun 2013 16:26:57 -0700, Zach Brown wrote: On Tue, Jun 04, 2013 at 07:16:53PM -0400, Chris Mason wrote: Quoting Zach Brown (2013-06-04 18:17:54) Hi gang, I finally sat down to fix that readdir hang that has been in the back of my mind for a while. I *hope* that the fix is