Re: [PATCH 1/2] btrfs: assert for num_devices below 0

2018-08-15 Thread Anand Jain
On 08/15/2018 08:11 PM, David Sterba wrote: On Fri, Aug 10, 2018 at 01:53:20PM +0800, Anand Jain wrote: In preparation to add helper function to deduce the num_devices with replace running, use assert instead of bug_on and warn_on. Signed-off-by: Anand Jain --- fs/btrfs/volumes.c | 4 ++--

Re: [PATCH 1/2] btrfs: assert for num_devices below 0

2018-08-15 Thread David Sterba
On Fri, Aug 10, 2018 at 01:53:20PM +0800, Anand Jain wrote: > In preparation to add helper function to deduce the num_devices with > replace running, use assert instead of bug_on and warn_on. > > Signed-off-by: Anand Jain > --- > fs/btrfs/volumes.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH 1/2] btrfs: assert for num_devices below 0

2018-08-10 Thread David Sterba
On Fri, Aug 10, 2018 at 01:53:20PM +0800, Anand Jain wrote: > In preparation to add helper function to deduce the num_devices with > replace running, use assert instead of bug_on and warn_on. > > Signed-off-by: Anand Jain Ok for the updated condition as it's going to be used in the new helper.