Re: [PATCH 2/3] xfstests 265: add a prealloc and reserve test

2011-11-15 Thread Ben Myers
Hi Wu Bo,

On Thu, Nov 03, 2011 at 11:09:00AM +0800, WuBo wrote:
 This test is for preallocation test. If the disk is full, just with a prealloc
 file has some free space that prealloc early. We need to check whether the 
 write
 to the free space is success or not.
 
 Signed-off-by: Wu Bo wu...@cn.fujitsu.com

This test is failing for me because I don't have fallocate installed.  I
suggest the test could to be changed to check for binaries it uses,
possibly the version of those binaries, and then not run unless the
right ones are installed.  But the best I can do right now is make a
note of it.

Just a heads up.  ;)

Regards,
Ben

--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/3] xfstests 265: add a prealloc and reserve test

2011-11-15 Thread WuBo
On 11/16/2011 03:08 AM, Christoph Hellwig wrote:
 On Tue, Nov 15, 2011 at 12:21:13PM -0600, Ben Myers wrote:
 Hi Wu Bo,

 On Thu, Nov 03, 2011 at 11:09:00AM +0800, WuBo wrote:
 This test is for preallocation test. If the disk is full, just with a 
 prealloc
 file has some free space that prealloc early. We need to check whether the 
 write
 to the free space is success or not.

 Signed-off-by: Wu Bo wu...@cn.fujitsu.com

 This test is failing for me because I don't have fallocate installed.  I
 suggest the test could to be changed to check for binaries it uses,
 possibly the version of those binaries, and then not run unless the
 right ones are installed.  But the best I can do right now is make a
 note of it.
 
 It might be even better to just use the xfs_io falloc command as we
 generally expect an uptodate xfs_io for use with xfstests.

Got it.

thanks,
wubo

 
 --
 To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html