Re: [PATCH 2/5] btrfs: fix transaction leak and crash after cleaning up orphans on RO mount

2021-03-16 Thread Filipe Manana
On Tue, Mar 16, 2021 at 11:43 AM Filipe Manana wrote: > > On Tue, Mar 16, 2021 at 6:49 AM robbieko wrote: > > > > Hi All, > > > > The patch delayed find orphan roots. > > Move to after orphan cleanup with tree_root. > > I think this will cause all orphan items to be deleted > > when orphan cleanu

Re: [PATCH 2/5] btrfs: fix transaction leak and crash after cleaning up orphans on RO mount

2021-03-16 Thread Filipe Manana
On Tue, Mar 16, 2021 at 6:49 AM robbieko wrote: > > Hi All, > > The patch delayed find orphan roots. > Move to after orphan cleanup with tree_root. > I think this will cause all orphan items to be deleted > when orphan cleanup with tree_root. > Afterwards, find orphan roots cannot find > the subvo

Re: [PATCH 2/5] btrfs: fix transaction leak and crash after cleaning up orphans on RO mount

2021-03-15 Thread robbieko
Hi All, The patch delayed find orphan roots. Move to after orphan cleanup with tree_root. I think this will cause all orphan items to be deleted when orphan cleanup with tree_root. Afterwards, find orphan roots cannot find the subvolume being deleted. Is my suspicion correct? Thanks. Robbie Ko