Re: [PATCH v3 2/2] btrfs: Add new ioctl uapis for qgroup creation / removal
Hi Sargun, [auto build test WARNING on linus/master] [also build test WARNING on v4.13-rc1 next-20170717] [cannot apply to btrfs/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sargun-Dhillon/New-qgroup-creation-removal-ioctls/20170715-195435 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/compiler.h:260:8: sparse: attribute 'no_sanitize_address': unknown attribute >> fs/btrfs/tests/qgroup-tests.c:232:34: sparse: not enough arguments for >> function btrfs_create_qgroup fs/btrfs/tests/qgroup-tests.c:334:34: sparse: not enough arguments for function btrfs_create_qgroup fs/btrfs/tests/qgroup-tests.c: In function 'test_no_shared_qgroup': fs/btrfs/tests/qgroup-tests.c:232:8: error: too few arguments to function 'btrfs_create_qgroup' ret = btrfs_create_qgroup(NULL, fs_info, BTRFS_FS_TREE_OBJECTID); ^~~ In file included from fs/btrfs/tests/qgroup-tests.c:24:0: fs/btrfs/tests/../qgroup.h:127:5: note: declared here int btrfs_create_qgroup(struct btrfs_trans_handle *trans, ^~~ fs/btrfs/tests/qgroup-tests.c: In function 'test_multiple_refs': fs/btrfs/tests/qgroup-tests.c:334:8: error: too few arguments to function 'btrfs_create_qgroup' ret = btrfs_create_qgroup(NULL, fs_info, BTRFS_FIRST_FREE_OBJECTID); ^~~ In file included from fs/btrfs/tests/qgroup-tests.c:24:0: fs/btrfs/tests/../qgroup.h:127:5: note: declared here int btrfs_create_qgroup(struct btrfs_trans_handle *trans, ^~~ vim +232 fs/btrfs/tests/qgroup-tests.c faa2dbf0 Josef Bacik2014-05-07 219 b9ef22de Feifei Xu 2016-06-01 220 static int test_no_shared_qgroup(struct btrfs_root *root, b9ef22de Feifei Xu 2016-06-01 221 u32 sectorsize, u32 nodesize) faa2dbf0 Josef Bacik2014-05-07 222 { faa2dbf0 Josef Bacik2014-05-07 223 struct btrfs_trans_handle trans; faa2dbf0 Josef Bacik2014-05-07 224 struct btrfs_fs_info *fs_info = root->fs_info; 442244c9 Qu Wenruo 2015-04-16 225 struct ulist *old_roots = NULL; 442244c9 Qu Wenruo 2015-04-16 226 struct ulist *new_roots = NULL; faa2dbf0 Josef Bacik2014-05-07 227 int ret; faa2dbf0 Josef Bacik2014-05-07 228 7c55ee0c Omar Sandoval 2015-09-29 229 btrfs_init_dummy_trans(); faa2dbf0 Josef Bacik2014-05-07 230 faa2dbf0 Josef Bacik2014-05-07 231 test_msg("Qgroup basic add\n"); ef9f2db3 Feifei Xu 2016-06-01 @232 ret = btrfs_create_qgroup(NULL, fs_info, BTRFS_FS_TREE_OBJECTID); faa2dbf0 Josef Bacik2014-05-07 233 if (ret) { faa2dbf0 Josef Bacik2014-05-07 234 test_msg("Couldn't create a qgroup %d\n", ret); faa2dbf0 Josef Bacik2014-05-07 235 return ret; faa2dbf0 Josef Bacik2014-05-07 236 } faa2dbf0 Josef Bacik2014-05-07 237 442244c9 Qu Wenruo 2015-04-16 238 /* 01327610 Nicholas D Steeves 2016-05-19 239 * Since the test trans doesn't have the complicated delayed refs, 442244c9 Qu Wenruo 2015-04-16 240 * we can only call btrfs_qgroup_account_extent() directly to test 442244c9 Qu Wenruo 2015-04-16 241 * quota. 442244c9 Qu Wenruo 2015-04-16 242 */ b9ef22de Feifei Xu 2016-06-01 243 ret = btrfs_find_all_roots(, fs_info, nodesize, 0, _roots); faa2dbf0 Josef Bacik2014-05-07 244 if (ret) { 442244c9 Qu Wenruo 2015-04-16 245 ulist_free(old_roots); 442244c9 Qu Wenruo 2015-04-16 246 test_msg("Couldn't find old roots: %d\n", ret); faa2dbf0 Josef Bacik2014-05-07 247 return ret; faa2dbf0 Josef Bacik2014-05-07 248 } faa2dbf0 Josef Bacik2014-05-07 249 ef9f2db3 Feifei Xu 2016-06-01 250 ret = insert_normal_tree_ref(root, nodesize, nodesize, 0, ef9f2db3 Feifei Xu 2016-06-01 251 BTRFS_FS_TREE_OBJECTID); faa2dbf0 Josef Bacik2014-05-07 252 if (ret) faa2dbf0 Josef Bacik2014-05-07 253 return ret; faa2dbf0 Josef Bacik2014-05-07 254 b9ef22de Feifei Xu 2016-06-01 255 ret = btrfs_find_all_roots(, fs_info, nodesize, 0, _roots); 442244c9 Qu Wenruo 2015-04-16 256 if (ret) { 442244c9 Qu Wenruo 2015-04-16 257 ulist_free(old_roots); 442244c9 Qu Wenruo 2015-04-16 258 ulist_free(new_roots); 442244c9 Qu Wenruo 2015-04-16 259 test_msg("Couldn't find old roots: %d\n", ret); 442244c9 Qu Wenruo 2015-04-16 260 return ret; 442244c9 Qu Wenruo
Re: [PATCH v3 2/2] btrfs: Add new ioctl uapis for qgroup creation / removal
Hi Sargun, [auto build test ERROR on linus/master] [also build test ERROR on v4.12 next-20170714] [cannot apply to btrfs/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sargun-Dhillon/New-qgroup-creation-removal-ioctls/20170715-195435 config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=xtensa All errors (new ones prefixed by >>): fs/btrfs/tests/qgroup-tests.c: In function 'test_no_shared_qgroup': >> fs/btrfs/tests/qgroup-tests.c:232:8: error: too few arguments to function >> 'btrfs_create_qgroup' ret = btrfs_create_qgroup(NULL, fs_info, BTRFS_FS_TREE_OBJECTID); ^ In file included from fs/btrfs/tests/qgroup-tests.c:24:0: fs/btrfs/tests/../qgroup.h:127:5: note: declared here int btrfs_create_qgroup(struct btrfs_trans_handle *trans, ^ fs/btrfs/tests/qgroup-tests.c: In function 'test_multiple_refs': fs/btrfs/tests/qgroup-tests.c:334:8: error: too few arguments to function 'btrfs_create_qgroup' ret = btrfs_create_qgroup(NULL, fs_info, BTRFS_FIRST_FREE_OBJECTID); ^ In file included from fs/btrfs/tests/qgroup-tests.c:24:0: fs/btrfs/tests/../qgroup.h:127:5: note: declared here int btrfs_create_qgroup(struct btrfs_trans_handle *trans, ^ vim +/btrfs_create_qgroup +232 fs/btrfs/tests/qgroup-tests.c faa2dbf0 Josef Bacik2014-05-07 219 b9ef22de Feifei Xu 2016-06-01 220 static int test_no_shared_qgroup(struct btrfs_root *root, b9ef22de Feifei Xu 2016-06-01 221 u32 sectorsize, u32 nodesize) faa2dbf0 Josef Bacik2014-05-07 222 { faa2dbf0 Josef Bacik2014-05-07 223 struct btrfs_trans_handle trans; faa2dbf0 Josef Bacik2014-05-07 224 struct btrfs_fs_info *fs_info = root->fs_info; 442244c9 Qu Wenruo 2015-04-16 225 struct ulist *old_roots = NULL; 442244c9 Qu Wenruo 2015-04-16 226 struct ulist *new_roots = NULL; faa2dbf0 Josef Bacik2014-05-07 227 int ret; faa2dbf0 Josef Bacik2014-05-07 228 7c55ee0c Omar Sandoval 2015-09-29 229 btrfs_init_dummy_trans(); faa2dbf0 Josef Bacik2014-05-07 230 faa2dbf0 Josef Bacik2014-05-07 231 test_msg("Qgroup basic add\n"); ef9f2db3 Feifei Xu 2016-06-01 @232 ret = btrfs_create_qgroup(NULL, fs_info, BTRFS_FS_TREE_OBJECTID); faa2dbf0 Josef Bacik2014-05-07 233 if (ret) { faa2dbf0 Josef Bacik2014-05-07 234 test_msg("Couldn't create a qgroup %d\n", ret); faa2dbf0 Josef Bacik2014-05-07 235 return ret; faa2dbf0 Josef Bacik2014-05-07 236 } faa2dbf0 Josef Bacik2014-05-07 237 442244c9 Qu Wenruo 2015-04-16 238 /* 01327610 Nicholas D Steeves 2016-05-19 239 * Since the test trans doesn't have the complicated delayed refs, 442244c9 Qu Wenruo 2015-04-16 240 * we can only call btrfs_qgroup_account_extent() directly to test 442244c9 Qu Wenruo 2015-04-16 241 * quota. 442244c9 Qu Wenruo 2015-04-16 242 */ b9ef22de Feifei Xu 2016-06-01 243 ret = btrfs_find_all_roots(, fs_info, nodesize, 0, _roots); faa2dbf0 Josef Bacik2014-05-07 244 if (ret) { 442244c9 Qu Wenruo 2015-04-16 245 ulist_free(old_roots); 442244c9 Qu Wenruo 2015-04-16 246 test_msg("Couldn't find old roots: %d\n", ret); faa2dbf0 Josef Bacik2014-05-07 247 return ret; faa2dbf0 Josef Bacik2014-05-07 248 } faa2dbf0 Josef Bacik2014-05-07 249 ef9f2db3 Feifei Xu 2016-06-01 250 ret = insert_normal_tree_ref(root, nodesize, nodesize, 0, ef9f2db3 Feifei Xu 2016-06-01 251 BTRFS_FS_TREE_OBJECTID); faa2dbf0 Josef Bacik2014-05-07 252 if (ret) faa2dbf0 Josef Bacik2014-05-07 253 return ret; faa2dbf0 Josef Bacik2014-05-07 254 b9ef22de Feifei Xu 2016-06-01 255 ret = btrfs_find_all_roots(, fs_info, nodesize, 0, _roots); 442244c9 Qu Wenruo 2015-04-16 256 if (ret) { 442244c9 Qu Wenruo 2015-04-16 257 ulist_free(old_roots); 442244c9 Qu Wenruo 2015-04-16 258 ulist_free(new_roots); 442244c9 Qu Wenruo 2015-04-16 259 test_msg("Couldn't find old roots: %d\n", ret); 442244c9 Qu Wenruo 2015-04-16 260 return ret; 442244c9 Qu Wenruo 2015-04-16 261 } 442244c9 Qu Wenruo 2015-04-16 262 b9ef22de Feifei Xu 2016-06-01 263 ret =