Re: Btrfs progs release 5.10.1

2021-02-19 Thread David Sterba
On Tue, Feb 16, 2021 at 11:00:18AM +, Filipe Manana wrote:
> On Fri, Feb 5, 2021 at 11:33 AM David Sterba  wrote:
> >
> > Hi,
> >
> > btrfs-progs version 5.10.1 have been released.
> >
> > The static build got broken due to libmount added in 5.10, this works now. 
> > The
> > minimum libmount version is 2.24 that is not available on some LTS distros 
> > like
> > CentOS 7. The plan is to bring the support back, reimplementing some 
> > libmount
> > functionality and dropping the dependency again.
> >
> > Tarballs: https://www.kernel.org/pub/linux/kernel/people/kdave/btrfs-progs/
> > Git: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git
> >
> > Shortlog:
> >
> > David Sterba (6):
> >   btrfs-progs: build: fix linking with static libmount
> 
> Btw, this causes two fstests to fail:
> 
> $ ./check btrfs/100 btrfs/101
> FSTYP -- btrfs
> PLATFORM  -- Linux/x86_64 debian8 5.11.0-rc6-btrfs-next-80 #1 SMP
> PREEMPT Wed Feb 3 11:28:05 WET 2021
> MKFS_OPTIONS  -- /dev/sdc
> MOUNT_OPTIONS -- /dev/sdc /home/fdmanana/btrfs-tests/scratch_1
> 
> btrfs/100 6s ... [failed, exit status 1]- output mismatch (see
> /home/fdmanana/git/hub/xfstests/results//btrfs/100.out.bad)
> --- tests/btrfs/100.out 2020-06-10 19:29:03.818519162 +0100
> +++ /home/fdmanana/git/hub/xfstests/results//btrfs/100.out.bad
> 2021-02-16 10:55:53.145343890 +
> @@ -2,10 +2,7 @@
>  Label: none  uuid: 
>   Total devices  FS bytes used 
>   devid  size  used  path SCRATCH_DEV
> - devid  size  used  path /dev/mapper/error-test
> + devid  size  used  path dm-0
> 
> -Label: none  uuid: 
> ...
> (Run 'diff -u /home/fdmanana/git/hub/xfstests/tests/btrfs/100.out
> /home/fdmanana/git/hub/xfstests/results//btrfs/100.out.bad'  to see
> the entire diff)
> btrfs/101 8s ... [failed, exit status 1]- output mismatch (see
> /home/fdmanana/git/hub/xfstests/results//btrfs/101.out.bad)
> --- tests/btrfs/101.out 2020-06-10 19:29:03.818519162 +0100
> +++ /home/fdmanana/git/hub/xfstests/results//btrfs/101.out.bad
> 2021-02-16 10:55:58.105503554 +
> @@ -2,10 +2,7 @@
>  Label: none  uuid: 
>   Total devices  FS bytes used 
>   devid  size  used  path SCRATCH_DEV
> - devid  size  used  path /dev/mapper/error-test
> + devid  size  used  path dm-0
> 
> -Label: none  uuid: 
> ...
> (Run 'diff -u /home/fdmanana/git/hub/xfstests/tests/btrfs/101.out
> /home/fdmanana/git/hub/xfstests/results//btrfs/101.out.bad'  to see
> the entire diff)
> Ran: btrfs/100 btrfs/101
> Failures: btrfs/100 btrfs/101
> Failed 2 of 2 tests
> 
> 
> Is there any plan to fix this?

Yes, it's fixed in devel, the path canonicalization got accidentally
broken by my libmount workarounds.


Re: Btrfs progs release 5.10.1

2021-02-16 Thread Filipe Manana
On Fri, Feb 5, 2021 at 11:33 AM David Sterba  wrote:
>
> Hi,
>
> btrfs-progs version 5.10.1 have been released.
>
> The static build got broken due to libmount added in 5.10, this works now. The
> minimum libmount version is 2.24 that is not available on some LTS distros 
> like
> CentOS 7. The plan is to bring the support back, reimplementing some libmount
> functionality and dropping the dependency again.
>
> Tarballs: https://www.kernel.org/pub/linux/kernel/people/kdave/btrfs-progs/
> Git: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git
>
> Shortlog:
>
> David Sterba (6):
>   btrfs-progs: build: fix linking with static libmount

Btw, this causes two fstests to fail:

$ ./check btrfs/100 btrfs/101
FSTYP -- btrfs
PLATFORM  -- Linux/x86_64 debian8 5.11.0-rc6-btrfs-next-80 #1 SMP
PREEMPT Wed Feb 3 11:28:05 WET 2021
MKFS_OPTIONS  -- /dev/sdc
MOUNT_OPTIONS -- /dev/sdc /home/fdmanana/btrfs-tests/scratch_1

btrfs/100 6s ... [failed, exit status 1]- output mismatch (see
/home/fdmanana/git/hub/xfstests/results//btrfs/100.out.bad)
--- tests/btrfs/100.out 2020-06-10 19:29:03.818519162 +0100
+++ /home/fdmanana/git/hub/xfstests/results//btrfs/100.out.bad
2021-02-16 10:55:53.145343890 +
@@ -2,10 +2,7 @@
 Label: none  uuid: 
  Total devices  FS bytes used 
  devid  size  used  path SCRATCH_DEV
- devid  size  used  path /dev/mapper/error-test
+ devid  size  used  path dm-0

-Label: none  uuid: 
...
(Run 'diff -u /home/fdmanana/git/hub/xfstests/tests/btrfs/100.out
/home/fdmanana/git/hub/xfstests/results//btrfs/100.out.bad'  to see
the entire diff)
btrfs/101 8s ... [failed, exit status 1]- output mismatch (see
/home/fdmanana/git/hub/xfstests/results//btrfs/101.out.bad)
--- tests/btrfs/101.out 2020-06-10 19:29:03.818519162 +0100
+++ /home/fdmanana/git/hub/xfstests/results//btrfs/101.out.bad
2021-02-16 10:55:58.105503554 +
@@ -2,10 +2,7 @@
 Label: none  uuid: 
  Total devices  FS bytes used 
  devid  size  used  path SCRATCH_DEV
- devid  size  used  path /dev/mapper/error-test
+ devid  size  used  path dm-0

-Label: none  uuid: 
...
(Run 'diff -u /home/fdmanana/git/hub/xfstests/tests/btrfs/101.out
/home/fdmanana/git/hub/xfstests/results//btrfs/101.out.bad'  to see
the entire diff)
Ran: btrfs/100 btrfs/101
Failures: btrfs/100 btrfs/101
Failed 2 of 2 tests


Is there any plan to fix this?

Thanks.


>   btrfs-progs: tests: add support to test the .static binaries
>   btrfs-progs: docs: clarify scrub requiring mounted filesystem
>   btrfs-progs: INSTALL: update build dependencies
>   btrfs-progs: update CHANGES for 5.10.1
>   Btrfs progs v5.10.1



-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”