Re: kernel BUG when fsync'ing file in a overlayfs merged dir, located on btrfs

2016-03-24 Thread Al Viro
On Thu, Mar 24, 2016 at 03:20:43PM +, Al Viro wrote: > > ocfs2_prepare_inode_for_write uses file->f_path.dentry for > > should_remove_suid (due to needing to do it early since cluster locking > > is unknown in setattr, according to the commit). Having > > should_remove_suid operate on an inod

Re: kernel BUG when fsync'ing file in a overlayfs merged dir, located on btrfs

2016-03-24 Thread Jeff Mahoney
On 3/24/16 11:20 AM, Al Viro wrote: > On Thu, Nov 05, 2015 at 11:03:58PM -0500, Jeff Mahoney wrote: > >> I suppose the irony here is that, AFAIK, that code is to ensure a file >> doesn't get lost between transactions due to rename. >> >> Isn't the file->f_path.dentry relationship stable otherwise,

Re: kernel BUG when fsync'ing file in a overlayfs merged dir, located on btrfs

2016-03-24 Thread Al Viro
On Thu, Nov 05, 2015 at 11:03:58PM -0500, Jeff Mahoney wrote: > I suppose the irony here is that, AFAIK, that code is to ensure a file > doesn't get lost between transactions due to rename. > > Isn't the file->f_path.dentry relationship stable otherwise, though? The > name might change and the pa

Re: kernel BUG when fsync'ing file in a overlayfs merged dir, located on btrfs

2015-11-06 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/5/15 11:03 PM, Jeff Mahoney wrote: > On 11/5/15 10:18 PM, Al Viro wrote: >> On Thu, Nov 05, 2015 at 09:57:35PM -0500, Jeff Mahoney wrote: >> >>> So now file_operations callbacks can't assume that >>> file->f_path.dentry belongs to the same file

Re: kernel BUG when fsync'ing file in a overlayfs merged dir, located on btrfs

2015-11-05 Thread Jeff Mahoney
On 11/5/15 10:18 PM, Al Viro wrote: > On Thu, Nov 05, 2015 at 09:57:35PM -0500, Jeff Mahoney wrote: > >> So now file_operations callbacks can't assume that file->f_path.dentry >> belongs to the same file system that implements the callback. More than >> that, any code that could ultimately get a

Re: kernel BUG when fsync'ing file in a overlayfs merged dir, located on btrfs

2015-11-05 Thread Al Viro
On Thu, Nov 05, 2015 at 09:57:35PM -0500, Jeff Mahoney wrote: > So now file_operations callbacks can't assume that file->f_path.dentry > belongs to the same file system that implements the callback. More than > that, any code that could ultimately get a dentry that comes from an > open file can't

Re: kernel BUG when fsync'ing file in a overlayfs merged dir, located on btrfs

2015-11-05 Thread Jeff Mahoney
On 9/30/15 3:57 PM, Roman Lebedev wrote: > Hello. > > My / is btrfs. > To do some my local stuff more cleanly i wanted to use overlayfs, > but it didn't quite work. > > Simple non-automatic sequence to reproduce the issue: > mkdir lower upper work merged > mount -t overlay overlay -olowerdir=l