[Linux-cachefs] [PATCH 04/12] fscache, cachefiles: Fix checker warnings

2018-04-04 Thread David Howells
Fix a couple of checker warnings in fscache and cachefiles: (1) fscache_n_op_requeue is never used, so get rid of it. (2) cachefiles_uncache_page() is passed in a lock that it releases, so this needs annotating. Signed-off-by: David Howells ---

[Linux-cachefs] [PATCH 07/12] fscache: Fix hanging wait on page discarded by writeback

2018-04-04 Thread David Howells
If the fscache asynchronous write operation elects to discard a page that's pending storage to the cache because the page would be over the store limit then it needs to wake the page as someone may be waiting on completion of the write. The problem is that the store limit may be updated by a

[Linux-cachefs] [PATCH 05/12] fscache: Pass the correct cancelled indications to fscache_op_complete()

2018-04-04 Thread David Howells
The last parameter to fscache_op_complete() is a bool indicating whether or not the operation was cancelled. A lot of the time the inverse value is given or no differentiation is made. Fix this. Signed-off-by: David Howells --- fs/fscache/page.c | 15

[Linux-cachefs] [PATCH 06/12] fscache: Detect multiple relinquishment of a cookie

2018-04-04 Thread David Howells
Report if an fscache cookie is relinquished multiple times by the netfs. Signed-off-by: David --- fs/fscache/cookie.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/fscache/cookie.c b/fs/fscache/cookie.c index d705125665f0..98d22f495cd8 100644

Re: [Linux-cachefs] [PATCH 06/12] fscache: Detect multiple relinquishment of a cookie

2018-04-04 Thread Linus Torvalds
On Wed, Apr 4, 2018 at 3:07 PM, David Howells wrote: > Report if an fscache cookie is relinquished multiple times by the netfs. > > - set_bit(FSCACHE_COOKIE_RELINQUISHED, >flags); > + if (test_and_set_bit(FSCACHE_COOKIE_RELINQUISHED, >flags)) > +

Re: [Linux-cachefs] [PATCH net-next 00/12] fscache: Fixes, traces and development

2018-04-04 Thread David Howells
> Subject: [PATCH net-next 00/12] fscache: Fixes, traces and development Apologies: that shouldn't say net-next in there. Cut'n'paste error. David -- Linux-cachefs mailing list Linux-cachefs@redhat.com https://www.redhat.com/mailman/listinfo/linux-cachefs