Fix a couple of checker warnings in fscache and cachefiles:
(1) fscache_n_op_requeue is never used, so get rid of it.
(2) cachefiles_uncache_page() is passed in a lock that it releases, so
this needs annotating.
Signed-off-by: David Howells
---
If the fscache asynchronous write operation elects to discard a page that's
pending storage to the cache because the page would be over the store limit
then it needs to wake the page as someone may be waiting on completion of
the write.
The problem is that the store limit may be updated by a
The last parameter to fscache_op_complete() is a bool indicating whether or
not the operation was cancelled. A lot of the time the inverse value is
given or no differentiation is made. Fix this.
Signed-off-by: David Howells
---
fs/fscache/page.c | 15
Report if an fscache cookie is relinquished multiple times by the netfs.
Signed-off-by: David
---
fs/fscache/cookie.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/fscache/cookie.c b/fs/fscache/cookie.c
index d705125665f0..98d22f495cd8 100644
On Wed, Apr 4, 2018 at 3:07 PM, David Howells wrote:
> Report if an fscache cookie is relinquished multiple times by the netfs.
>
> - set_bit(FSCACHE_COOKIE_RELINQUISHED, >flags);
> + if (test_and_set_bit(FSCACHE_COOKIE_RELINQUISHED, >flags))
> +
> Subject: [PATCH net-next 00/12] fscache: Fixes, traces and development
Apologies: that shouldn't say net-next in there. Cut'n'paste error.
David
--
Linux-cachefs mailing list
Linux-cachefs@redhat.com
https://www.redhat.com/mailman/listinfo/linux-cachefs