Re: [PATCH] use mkstemp instead of mktemp

Hi, > > FILE *mnttmp, *mntmtab; > > struct mntent *mountent; > > char *mtabfile, *mtabdir, *mtabtmpfile; > > + mode_t mode; > > + FILE *spf; > > + int fd = -1 ; > > > > mtabfile = strdup(MOUNTED); > > mtabdir = dirname(mtabfile); > > @@ -1652,12 +1655,17 @@ del_mtab(cha

Re: [PATCH v2] mount.cifs: handle errors from rename() in del_mtab

Looks good, On Mon, Jan 16, 2012 at 01:23:13PM -0500, Jeff Layton wrote: > The new del_mtab code ignored errors from rename(). Make it handle that > error as well like it does other errors. > > Signed-off-by: Jeff Layton Reviewed-by: Carlos Maiolino > --- > mount.cifs.c

[PATCH] mount.cifs: Properly update mtab during remount V5

delete from the mtab, the old entry from the filesystem which is being remounted, and then, calls add_mtab() to add an updated entry to the mtab file. Signed-off-by: Carlos Maiolino --- mount.cifs.c | 100 +- 1 files changed, 99 insertions

[PATCH] mount.cifs: Properly update mtab during remount V4

will delete from the mtab, the old entry from the filesystem which is being remounted, and then, calls add_mtab() to add an updated entry to the mtab file. Signed-off-by: Carlos Maiolino --- mount.cifs.c | 98 ++ 1 files changed, 98

[PATCH] mount.cifs: Properly update mtab during remount V3

will delete from the mtab, the old entry from the filesystem which is being remounted, and then, calls add_mtab() to add an updated entry to the mtab file. Signed-off-by: Carlos Maiolino --- mount.cifs.c | 107 ++ 1 files changed, 107

Re: [PATCH] mount.cifs: Properly update mtab during remount V2

Hi Jeff On Tue, Jan 03, 2012 at 07:22:29AM -0500, Jeff Layton wrote: > > + > > + mtabfile = strdup(MOUNTED); > > This looks like a buffer overrun. Here, you're strduping MOUNTED... > > > + mtabdir = dirname(mtabfile); > > Then altering that string to get the dirname... > > > + if (!mtabdi

[PATCH] mount.cifs: Properly update mtab during remount V2

will delete from the mtab, the old entry from the filesystem which is being remounted, and then, calls add_mtab() to add an updated entry to the mtab file. Signed-off-by: Carlos Maiolino --- mount.cifs.c | 102 ++ 1 files changed, 102

Re: [PATCH] mount.cifs: Properly update mtab during remount

> > case the fs > > is being remounted. > > The del_mtab() function will delete from the mtab, the old entry from the > > filesystem which > > is being remounted, and then, calls add_mtab() to add an updated entry to > > the mtab file. > &g

Re: [PATCH] mount.cifs: Properly update mtab during remount

Guys, my apologies for the doubled message to the list, both patches are the same, I sent it two times by mistake. -- --Carlos -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel

[PATCH] mount.cifs: Properly update mtab during remount

will delete from the mtab, the old entry from the filesystem which is being remounted, and then, calls add_mtab() to add an updated entry to the mtab file. Signed-off-by: Carlos Maiolino --- mount.cifs.c | 81 ++ 1 files changed, 81

[PATCH] mount.cifs: Properly update mtab during remount

will delete from the mtab, the old entry from the filesystem which is being remounted, and then, calls add_mtab() to add an updated entry to the mtab file. Signed-off-by: Carlos Maiolino --- mount.cifs.c | 81 ++ 1 files changed, 81

[no subject]

subscribe -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html