[PATCH] [CIFS] fix auth_key cleanup in SMB2_sess_setup() for possible crash

2014-10-20 Thread Dan Aloni
The ses-auth_key.len field should be zeroed out during error paths, along with the 'response' field. Rationale: It is possible with a specially crafted SMB2 server to cause the setup to free the key but keep the session. When the session is recovered (after a connection drop, for example), the

Re: Kerberized mount.cifs with SMB1?

2014-10-20 Thread steve
On 19/10/14 22:48, Jurjen Bokma wrote: On 10/19/2014 10:42 PM, steve wrote: On 19/10/14 22:30, Jurjen Bokma wrote: So I would very much like to use SMB3 to get to the Windows file servers. Kerberized SMB1 worked like a charm. Speed/bandwidth is not really the issue here. Yeah, of course.

Re: Kerberized mount.cifs with SMB1?

2014-10-20 Thread Jurjen Bokma
On 10/20/2014 06:24 PM, steve wrote: On 19/10/14 22:48, Jurjen Bokma wrote: On 10/19/2014 10:42 PM, steve wrote: On 19/10/14 22:30, Jurjen Bokma wrote: So I would very much like to use SMB3 to get to the Windows file servers. Kerberized SMB1 worked like a charm. Speed/bandwidth is not

Status of SMB3?

2014-10-20 Thread Ben Greear
I notice at least some support for SMB3 in the 3.17 kernel. Any idea how complete SMB3 support is? Thanks, Ben -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line unsubscribe linux-cifs in the body of a

Re: Kerberized mount.cifs with SMB1?

2014-10-20 Thread Steve French
On Mon, Oct 20, 2014 at 11:37 AM, Jurjen Bokma j.bo...@rug.nl wrote: On 10/20/2014 06:24 PM, steve wrote: On 19/10/14 22:48, Jurjen Bokma wrote: On 10/19/2014 10:42 PM, steve wrote: On 19/10/14 22:30, Jurjen Bokma wrote: So I would very much like to use SMB3 to get to the Windows file

Re: Kerberized mount.cifs with SMB1?

2014-10-20 Thread Jurjen Bokma
On 10/20/2014 07:09 PM, Steve French wrote: On Mon, Oct 20, 2014 at 11:37 AM, Jurjen Bokma j.bo...@rug.nl wrote: On 10/20/2014 06:24 PM, steve wrote: On 19/10/14 22:48, Jurjen Bokma wrote: On 10/19/2014 10:42 PM, steve wrote: On 19/10/14 22:30, Jurjen Bokma wrote: So I would very much like

Re: Status of SMB3?

2014-10-20 Thread Steve French
This is a great question to explore now that significant SMB3 improvements have gone into 3.17. SMB3 stability is much improved recently, in part due to the focus on automated xfstesting over the past months. In addition, it is much more posix compatible now. High level view: - SMB3 generally

Re: Status of SMB3?

2014-10-20 Thread Steve French
I should have mentioned that the mfsymlinks and apple style remap changes are in 3.18-rc1 not in 3.17 On Mon, Oct 20, 2014 at 12:33 PM, Steve French smfre...@gmail.com wrote: This is a great question to explore now that significant SMB3 improvements have gone into 3.17. SMB3 stability is much

Re: Status of SMB3?

2014-10-20 Thread Ben Greear
On 10/20/2014 10:35 AM, Steve French wrote: I should have mentioned that the mfsymlinks and apple style remap changes are in 3.18-rc1 not in 3.17 Thanks for the detailed update. We'll add support for it in our testing tool (which is primarily used to generate lots and lots of client cifs

[PATCH 1/3] Add missing defines for ACL query support

2014-10-20 Thread Steve French
Add missing defines needed for ACL query support. For definitions of these security info type additionalinfo flags and also the EA Flags see MS-SMB2 (2.2.37) or MS-DTYP Signed-of-by: Steven French smfre...@gmail.com Reviewed-by: Shirish Pargaonkar shirishpargaon...@gmail.com ---

[PATCH 2/3] [SMB3] decode_negTokenInit had wrong calling sequence

2014-10-20 Thread Steve French
For krb5 enablement of SMB3, decoding negprot, caller now passes server struct not the old sec_type --- fs/cifs/smb2pdu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index 8f1672b..0ca7f63 100644 --- a/fs/cifs/smb2pdu.c +++

[PATCH 3/3] [CIFS] Update modinfo cifs version for cifs.ko

2014-10-20 Thread Steve French
update cifs version to 2.06 Signed-off-by: Steve French smfre...@gmail.com --- fs/cifs/cifsfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/cifsfs.h b/fs/cifs/cifsfs.h index 002e0c1..252f5c1 100644 --- a/fs/cifs/cifsfs.h +++ b/fs/cifs/cifsfs.h @@ -136,5 +136,5 @@

[PATCH 1/4] Add support for original fallocate

2014-10-20 Thread Steve French
In many cases the simple fallocate call is a no op (since the file is already not sparse) or can simply be converted from a sparse to a non-sparse file if we are fallocating the whole file and keeping the size. Signed-off-by: Steven French smfre...@gmail.com --- fs/cifs/smb2ops.c | 63