[PATCH 00/11] Push file_update_time() into .page_mkwrite

2012-02-16 Thread Jan Kara
Hello, to provide reliable support for filesystem freezing, filesystems need to have complete control over when metadata is changed. In particular, file_update_time() calls from page fault code make it impossible for filesystems to prevent inodes from being dirtied while the filesystem is

[PATCH 05/11] cifs: Push file_update_time() into cifs_page_mkwrite()

2012-02-16 Thread Jan Kara
CC: Steve French sfre...@samba.org CC: linux-cifs@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- fs/cifs/file.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) BTW: How does cifs_page_mkwrite() protect against races with truncate? See e.g. checks in __block_page_mkwrite

[PATCH 4/9] cifs: Push file_update_time() into cifs_page_mkwrite()

2012-03-01 Thread Jan Kara
CC: Steve French sfre...@samba.org CC: linux-cifs@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- fs/cifs/file.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 4dd9283..8e3b23b 100644 --- a/fs/cifs/file.c +++ b/fs/cifs

Re: [PATCH 4/9] cifs: Push file_update_time() into cifs_page_mkwrite()

2012-03-01 Thread Jan Kara
On Thu 01-03-12 07:25:37, Jeff Layton wrote: On Thu, 1 Mar 2012 12:41:38 +0100 Jan Kara j...@suse.cz wrote: CC: Steve French sfre...@samba.org CC: linux-cifs@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- fs/cifs/file.c |3 +++ 1 files changed, 3 insertions(+), 0

Re: [PATCH 00/11 v2] Push file_update_time() into .page_mkwrite

2012-03-02 Thread Jan Kara
On Thu 01-03-12 18:29:42, Ted Tso wrote: On Thu, Mar 01, 2012 at 12:41:34PM +0100, Jan Kara wrote: To fix the issue, this patch set changes page fault code to call file_update_time() only when -page_mkwrite() callback is not provided. If the callback is provided

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Jan Kara
ncp_file_mmap does not set .mkwrite - it should use filemap_page_mkwrite() I think. Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-cifs in the body of a message to majord

Re: [PATCH 2/3] mm: Only enforce stable page writes if the backing device requires it

2012-11-01 Thread Jan Kara
. Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-cifs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] bdi: Track users that require stable page writes

2012-11-01 Thread Jan Kara
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-cifs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/3] bdi: Track users that require stable page writes

2012-11-01 Thread Jan Kara
the FSs that do care, already take care of it. I'm not exactly sure whether FSs that do care didn't start to use generic functions which now always call wait_on_page_writeback() for quite a few releases... Honza -- Jan Kara j

Re: [PATCH 0/3] Extended file stat functions [ver #2]

2013-11-26 Thread Jan Kara
something with a 4Gb+ blocksize? (4) Should the inode number and data version number fields be 128-bit? -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-cifs in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 0/3] Extended file stat functions [ver #2]

2013-11-28 Thread Jan Kara
On Thu 28-11-13 13:07:24, David Howells wrote: Jan Kara j...@suse.cz wrote: unsigned long long st_blocks; When we are doing this, can we please also change 'st_blocks' to 'st_bytes'? We track space usage in kernel in bytes for a long time so it would be nice

Re: [PATCH v5 6/7] fs: pass iocb to generic_write_sync

2014-11-06 Thread Jan Kara
. - gfs2 also used generic_write_sync to implement a crude version of fallocate. It has been switched to use an open coded variant instead. Signed-off-by: Christoph Hellwig h...@lst.de Looks good. You can add: Reviewed-by: Jan Kara j...@suse.cz