Re: [PATCH 2/3] [CRYPTO] Add optimized SHA-1 implementation for i486+

2007-06-10 Thread Matt Mackall
On Sun, Jun 10, 2007 at 12:47:19PM -0400, Benjamin Gilbert wrote: > Matt Mackall wrote: > >On Sat, Jun 09, 2007 at 08:33:25PM -0400, Benjamin Gilbert wrote: > >>It's not just the loop unrolling; it's the register allocation and > >>spilling. For comparison, I built SHATransform() from the > >>dr

Re: [PATCH 2/3] [CRYPTO] Add optimized SHA-1 implementation for i486+

2007-06-10 Thread Benjamin Gilbert
Matt Mackall wrote: On Sat, Jun 09, 2007 at 08:33:25PM -0400, Benjamin Gilbert wrote: It's not just the loop unrolling; it's the register allocation and spilling. For comparison, I built SHATransform() from the drivers/char/random.c in 2.6.11, using gcc 3.3.5 with -O2 and SHA_CODE_SIZE == 3 (

Re: [PATCH 2/3] [CRYPTO] Add optimized SHA-1 implementation for i486+

2007-06-10 Thread Matt Mackall
On Sat, Jun 09, 2007 at 08:33:25PM -0400, Benjamin Gilbert wrote: > Jeff Garzik wrote: > >Matt Mackall wrote: > >>Have you benchmarked this against lib/sha1.c? Please post the results. > >>Until then, I'm frankly skeptical that your unrolled version is faster > >>because when I introduced lib/sha1.