Re: [CRYPTO] blkcipher: Add IV generation

2007-10-01 Thread Herbert Xu
Joy Latten <[EMAIL PROTECTED]> wrote: > > So, I am thinking CTR and some of the other modes, > other than CBC, that use an IV will fail with this > change since they currently don't have an alg->geniv... > should they have a geniv similar to that of CBC, which > is gotten randomly? The only oth

Re: [CRYPTO] blkcipher: Add IV generation

2007-10-01 Thread Joy Latten
{ @@ -434,8 +450,16 @@ static int crypto_init_blkcipher_ops_async(struct crypto_tfm *tfm) crt->setkey = async_setkey; crt->encrypt = async_encrypt; crt->decrypt = async_decrypt; + crt->geniv = async_geniv; crt->ivsize = alg->ivsize; + if (!alg->geniv)

Re: [PATCH 1/1]: Revised CTR mode implementation

2007-10-01 Thread Joy Latten
>On Thu, Sep 27, 2007 at 03:54:51PM -0500, Joy Latten wrote: >> >>So, for example, >> >> ctr(aes,4,8) >> >>specifies the counter block will be composed of 4 bytes from a >>nonce and 8 bytes from the IV and 4 bytes for counter, which is set. > >Could you please add a check

[RFC/Patch] fix typo on algorithm comparison

2007-10-01 Thread Sebastian Siewior
The compare code which looks for identical driver compares "driver name" with "algorithm name" instead of "driver name" with "driver name". Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> --- Herbert, it looks like a typo to me. I'm not sure. --- a/crypto/algapi.c +++ b/crypto/algapi.c @@

Re: [1/1] HIFN 795x driver.

2007-10-01 Thread Sebastian Siewior
* Evgeniy Polyakov | 2007-10-01 16:48:22 [+0400]: Hello Evgeniy, >optimisations. It also refuses to register 'ecb(des)' with min and max >keylen set to the same number, so right now des and 3des are removed. I don't know if I understood you correctly but keep this in mind: min and max key size is

Re: Tcrypt output for HIFN 795x driver.

2007-10-01 Thread Evgeniy Polyakov
On Mon, Oct 01, 2007 at 09:15:57PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: > On Mon, Oct 01, 2007 at 04:51:06PM +0400, Evgeniy Polyakov wrote: > > Notice that 'testing ecb(aes) decryption across pages (chunking)' fails. > > I will investigate this further. > > Thre aren't any ecb chunking tes

Re: Tcrypt output for HIFN 795x driver.

2007-10-01 Thread Herbert Xu
On Mon, Oct 01, 2007 at 04:51:06PM +0400, Evgeniy Polyakov wrote: > Notice that 'testing ecb(aes) decryption across pages (chunking)' fails. > I will investigate this further. Thre aren't any ecb chunking tests. Looks like it's the cbc test that's failing. Cheers, -- Visit Openswan at http://ww

Re: [1/1] HIFN 795x driver.

2007-10-01 Thread Evgeniy Polyakov
On Mon, Oct 01, 2007 at 04:48:22PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > Hi. > > This is a driver for HIFN 795x crypo accelerator chips. > In the next mail I will send tcrypt default output related to this > driver, it outlines several failures (I need to check what 'chunking' > me

Tcrypt output for HIFN 795x driver.

2007-10-01 Thread Evgeniy Polyakov
Notice that 'testing ecb(aes) decryption across pages (chunking)' fails. I will investigate this further. [ 628.851890] testing ecb(aes) encryption [ 628.857498] hifn_cra_init: tfm: 81003a8739c8, dev: hifn0 [81003dd7c2c8]. [ 628.865046] test 1 (128 bit key): [ 628.868505] hifn_setkey: