Re: [PATCH] [crypto] load the SHA1[1|256] module by an alias (v2)

On Fri, Oct 05, 2007 at 03:12:10PM +0200, Sebastian Siewior wrote: > Loading the crypto algorithm by the alias instead of by module directly > has the advantage that all possible implementations of this algorithm > are loaded automatically and the crypto API can choose the best one > depending on i

Re: [PATCH] [crypto] load the SHA1[1|256] module by an alias

On Fri, Oct 05, 2007 at 03:50:56PM +0200, Sebastian Siewior wrote: > > I did not find a module_mutex. We hold a readlock of crypto_alg_sem > within the crypto subsystem and request_module() increments > kmod_concurrent (which may not exceed a certain limit). Yes you're right. The module_mutex (i

[PATCH] [crypto] load the SHA1[1|256] module by an alias (v2)

Loading the crypto algorithm by the alias instead of by module directly has the advantage that all possible implementations of this algorithm are loaded automatically and the crypto API can choose the best one depending on its priority. Additionally it ensures that the generic implementation as wel

Re: [PATCH] [crypto] load the SHA1[1|256] module by an alias

* Herbert Xu | 2007-10-05 16:57:44 [+0800]: >This patch is correct per se but it combined with the code in >padlock-sha can cause a dead-lock. Padlock-sha tries to load >the generic sha module in its init function. At this point it >is still holding the module_mutex so the probe will dead-lock.

Re: [PATCH] [crypto] load the SHA1[1|256] module by an alias

On Thu, Oct 04, 2007 at 09:37:39AM +0200, Sebastian Siewior wrote: > Loading the crypto algorithm by the alias instead of by module directly > has the advantage that all possible implementations of this algorithm > are loaded automatically and the crypto API can choose the best one > depending on i

Re: [PATCH] [crypto] load the AES module by an alias

On Thu, Oct 04, 2007 at 09:37:27AM +0200, Sebastian Siewior wrote: > Loading the crypto algorithm by the alias instead of by module directly > has the advantage that all possible implementations of this algorithm > are loaded automatically and the crypto API can choose the best one > depending on i

Re: [PATCH] [crypto] load the DES module by an alias

On Wed, Oct 03, 2007 at 09:23:37PM +0200, Sebastian Siewior wrote: > Loading the crypto algorithm by the alias instead of by module directly > has the advantage that all possible implementations of this algorithm > are loaded automatically and the crypto API can choose the best one > depending on i

Re: [1/1 take 2] HIFN 795x driver.

On Thu, Oct 04, 2007 at 07:04:53PM +0400, Evgeniy Polyakov wrote: > > It just can not be used in asynchronous hardware, so I will create > soemthing new for HIFN driver specially. That sounds good. We can put it into ablkcipher.c and then get rid of the phys stuff from blkcipher.c. Cheers, -- V