Use proper defines for constants even if they point to the same
value:
- there is no min/max blocksize, there is one for AES.
- the size of the IV is the algorithm's block size in case of CBC.
- there is no key size for AES but three different :)
This is a nitpicker patch, no added value :)
Sign
It is enough if the IV is copied before and after the while loop.
With DM-Crypt is seems not be required to save the IV after encrytion
because a new IV is used in the request (dunno about other users).
It is not save to load the IV within while loop and not save afterwards
because we will end up
The Geode AES crypto engine supports only 128 bit long key. This
patch adds fallback for other key sizes which are required by the
AES standard.
Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
---
drivers/crypto/geode-aes.c | 188 +++-
drivers/crypto
Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
---
drivers/crypto/geode-aes.c | 32
drivers/crypto/geode-aes.h | 36 ++--
2 files changed, 34 insertions(+), 34 deletions(-)diff --git a/drivers/crypto/geode-aes.c b/drivers/
The code waits in a busy loop until the hardware finishes the encryption
or decryption process. This wants a cpu_relax() :)
The busy loop finishes either if the encryption is done or if the counter
is zero. If the latter is true than the hardware failed. Since this
should not happen, leave a BUG()
This three defines are used in every AES related implementation.
Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
---
arch/i386/crypto/aes.c |4 +---
arch/s390/crypto/aes_s390.c |7 +--
arch/x86_64/crypto/aes.c |6 +-
crypto/aes.c |6 +-
Hello Herbert,
This patchset started in order to verify broken Geode driver [1] without
the actual hardware. [2] contains a version of the geode-aes driver where
the hardware routines are replaced with software because I assume that
the hardware is actually working (and this is the closest I get)