Re: IV copy strategy

2007-11-15 Thread Herbert Xu
On Thu, Nov 15, 2007 at 10:10:05PM +0100, Sebastian Siewior wrote: > > In this case, the s390 has the same bug (they copy the IV back after > blkcipher_walk_done()). Howevere it will probably never get triggered > because they have an aligment of 0 (what gets pushed to 3 by the crypto > API if I re

[PATCH] [crypto] geode: do not copy the IV too often

2007-11-15 Thread Sebastian Siewior
There is no reason to keep the IV in the private structre. This also remove a few memcpy()s Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> --- Herbert, could I please squash that one into the bad one so there are no broken commits? diff --git a/drivers/crypto/geode-aes.c b/drivers/crypto/g

Re: IV copy strategy

2007-11-15 Thread Sebastian Siewior
* Herbert Xu | 2007-11-14 22:22:53 [+0800]: >Indeed the last call to blkcipher_walk_done will free the IV if >we had to copy it due to an alignment mismatch. Since geode has >an alignment of 16 bytes, that's almost a given. Ach >You could copy from/to desc->info instead which would solve the >pr

[PATCH 1/1] salsa20: Salsa20 stream cipher

2007-11-15 Thread Tan Swee Heng
This patch implements the Salsa20 stream cipher using the blkcipher interface. The core cipher code comes from Daniel Bernstein's submission to eSTREAM: http://www.ecrypt.eu.org/stream/svn/viewcvs.cgi/ecrypt/trunk/submissions/salsa20/full/ref/ The test vectors comes from: http://www.ecrypt.