Re: [PATCH -mm crypto] AES: x86_64 asm implementation optimization

2008-04-29 Thread Sebastian Siewior
* Huang, Ying | 2008-04-25 11:11:17 [+0800]: >Hi, Sebastian, Hi Huang, sorry for the delay. >I changed the patches to group the read or write together instead of >interleaving. Can you help me to test these new patches? The new patches >is attached with the mail. The new results are attached. >

Re: [RFC XFRM]: esp: fix scatterlist of out bounds access with crypto_eseqiv

2008-04-29 Thread Evgeniy Polyakov
On Tue, Apr 29, 2008 at 10:45:03PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: > On Tue, Apr 29, 2008 at 06:21:44PM +0400, Evgeniy Polyakov wrote: > > > > Hey, it works :)) > > Just not always, which is great at attracting Patrick and problems. > > I was more commenting on the bugs in the crypto

Re: [revised PATCH] crypto: Correct kzalloc error test

2008-04-29 Thread Herbert Xu
On Tue, Apr 29, 2008 at 04:18:08PM +0200, Julia Lawall wrote: > From: Julia Lawall <[EMAIL PROTECTED]> > > Normally, kzalloc returns NULL or a valid pointer value, not a value to be > tested using IS_ERR. > > Signed-off-by: Julia Lawall <[EMAIL PROTECTED]> Patch applied. Thanks Julia! -- Visit

Re: [RFC XFRM]: esp: fix scatterlist of out bounds access with crypto_eseqiv

2008-04-29 Thread Herbert Xu
On Tue, Apr 29, 2008 at 06:21:44PM +0400, Evgeniy Polyakov wrote: > > Hey, it works :)) > Just not always, which is great at attracting Patrick and problems. I was more commenting on the bugs in the crypto layer that breaks hifn rather than the hifn driver itself :) Cheers, -- Visit Openswan at

Re: [revised PATCH] crypto: Correct kzalloc error test

2008-04-29 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> Normally, kzalloc returns NULL or a valid pointer value, not a value to be tested using IS_ERR. Signed-off-by: Julia Lawall <[EMAIL PROTECTED]> --- diff -u -p a/crypto/cryptd.c b/crypto/cryptd.c --- a/crypto/cryptd.c 2008-04-16 13:27:56.0 +0200 ++

Re: [RFC XFRM]: esp: fix scatterlist of out bounds access with crypto_eseqiv

2008-04-29 Thread Evgeniy Polyakov
On Tue, Apr 29, 2008 at 09:59:32PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: > It's a good thing the hifn driver doesn't work yet :) Hey, it works :)) Just not always, which is great at attracting Patrick and problems. -- Evgeniy Polyakov -- To unsubscribe from this list: send the lin

Re: [RFC XFRM]: esp: fix scatterlist of out bounds access with crypto_eseqiv

2008-04-29 Thread Patrick McHardy
Patrick McHardy wrote: Herbert Xu wrote: On Tue, Apr 29, 2008 at 07:09:39AM +0200, Patrick McHardy wrote: I've attached two traces, the one from eseqiv and a similar one from authenc (I've manually overriden eseqiv by chainiv to test whether its responsible for the broken packets I was seeing

Re: [RFC XFRM]: esp: fix scatterlist of out bounds access with crypto_eseqiv

2008-04-29 Thread Patrick McHardy
Herbert Xu wrote: On Tue, Apr 29, 2008 at 07:09:39AM +0200, Patrick McHardy wrote: I've attached two traces, the one from eseqiv and a similar one from authenc (I've manually overriden eseqiv by chainiv to test whether its responsible for the broken packets I was seeing, which turned out to b

Re: [PATCH] crypto: Correct kzalloc error test

2008-04-29 Thread Herbert Xu
Julia Lawall <[EMAIL PROTECTED]> wrote: > From: Julia Lawall <[EMAIL PROTECTED]> > > Normally, kzalloc returns NULL or a valid pointer value, not a value to be > tested using IS_ERR. Ouch :) > diff -u -p a/crypto/cryptd.c b/crypto/cryptd.c > --- a/crypto/cryptd.c 2008-04-16 13:27:56.0

Re: [RFC XFRM]: esp: fix scatterlist of out bounds access with crypto_eseqiv

2008-04-29 Thread Herbert Xu
On Tue, Apr 29, 2008 at 07:09:39AM +0200, Patrick McHardy wrote: > > I've attached two traces, the one from eseqiv and a similar > one from authenc (I've manually overriden eseqiv by chainiv > to test whether its responsible for the broken packets I was > seeing, which turned out to be the case. I

[PATCH] crypto: Correct kzalloc error test

2008-04-29 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> Normally, kzalloc returns NULL or a valid pointer value, not a value to be tested using IS_ERR. Signed-off-by: Julia Lawall <[EMAIL PROTECTED]> --- diff -u -p a/crypto/cryptd.c b/crypto/cryptd.c --- a/crypto/cryptd.c 2008-04-16 13:27:56.0 +0200 ++