Re: [dm-devel] Desynchronizing dm-raid1

2008-05-21 Thread Herbert Xu
On Wed, May 21, 2008 at 10:18:43PM -0400, Mikulas Patocka wrote: > > All the ciphers comply, so the bug is only a theroretical issue (but I > didn't check assembler versions --- they should be checked by the person > who wrote them, assembler is write-only language). Since every current algorith

Re: [dm-devel] Desynchronizing dm-raid1

2008-05-21 Thread Mikulas Patocka
On Wed, 14 May 2008, Herbert Xu wrote: On Tue, May 13, 2008 at 04:35:03PM -0400, Mikulas Patocka wrote: And where would you propose to place this bit? One possibility would be struct crypto_tfm->crt_flags Another possibility is struct crypto_alg->cra_flags The latter definitely because th

Re: [PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-21 Thread Herbert Xu
On Wed, May 21, 2008 at 04:09:38PM -0400, Neil Horman wrote: > Patch to add checking of DES3 test vectors using CBC mode. FIPS-1402-2 > compliance mandates that any supported mode of oepration must include a self > test. This satisfies that requirement for cbc(des_ebe). Tested successfully > by

[PATCH] tcrypt: add self test for des3_ebe cipher operating in cbc mode

2008-05-21 Thread Neil Horman
Patch to add checking of DES3 test vectors using CBC mode. FIPS-1402-2 compliance mandates that any supported mode of oepration must include a self test. This satisfies that requirement for cbc(des_ebe). Tested successfully by me Regards Neil Signed-off-by: Neil Horman <[EMAIL PROTECTED]> tc

Re: [PATCH v2] crypto: rmd128: make it work on my prefered architecture

2008-05-21 Thread David Miller
From: Sebastian Siewior <[EMAIL PROTECTED]> Date: Wed, 21 May 2008 09:20:59 +0200 > Yes, that could be case. However a "manual" swap has three opcodes here, > the le load has one. I should not end up with more code in the latter > cases hould I? You indeed can, because GCC has less information to

Re: [PATCH v2] crypto: rmd128: make it work on my prefered architecture

2008-05-21 Thread Sebastian Siewior
* David Miller | 2008-05-21 00:11:42 [-0700]: >From: Sebastian Siewior <[EMAIL PROTECTED]> >Date: Wed, 21 May 2008 09:09:54 +0200 > >> That was, what I expected as well but the numbers were different. I >> checked the assembly code and I had the le loads but more code. I will >> check with differe

Re: [PATCH v2] crypto: rmd128: make it work on my prefered architecture

2008-05-21 Thread David Miller
From: Sebastian Siewior <[EMAIL PROTECTED]> Date: Wed, 21 May 2008 09:09:54 +0200 > That was, what I expected as well but the numbers were different. I > checked the assembly code and I had the le loads but more code. I will > check with different compiler maybe it will get better here as well. Y

Re: [PATCH v2] crypto: rmd128: make it work on my prefered architecture

2008-05-21 Thread Sebastian Siewior
* David Miller | 2008-05-20 19:47:23 [-0700]: >From: Herbert Xu <[EMAIL PROTECTED]> I though you and Herbert are two different persons. >Performance is significantly increased on Niagara2 by using >the little-endian loads inside of the transformation loop, as >expected. The numbers below are fi