Re: [PATCH v4] crypto: des3_ede: permit weak keys unless REQ_WEAK_KEY set

2008-12-08 Thread Jarod Wilson
While its a slightly insane to bypass the key1 == key2 || key2 == key3 check in triple-des, since it reduces it to the same strength as des, some folks do need to do this from time to time for backwards compatibility with des. My own case is FIPS CAVS test vectors. Many triple-des test vectors

Re: [PATCH] AMCC Crypto4xx Device Driver v4]

2008-12-08 Thread Kim Phillips
On Fri, 5 Dec 2008 06:41:13 +0100 Stefan Roese [EMAIL PROTECTED] wrote: On Friday 05 December 2008, Kim Phillips wrote: diff --git a/arch/powerpc/boot/dts/canyonlands.dts b/arch/powerpc/boot/dts/canyonlands.dts index 79fe412..b0f0096 100644 --- a/arch/powerpc/boot/dts/canyonlands.dts

Re: [PATCH] AMCC Crypto4xx Device Driver v4]

2008-12-08 Thread James Hsiao
Hi Kim, + /* figure how many gd is needed */ + if (aad_len) { + num_gd = get_sg_count(assoc, aad_len) + + get_sg_count(src, datalen); this is dead code - aad_len is never non-zero - is there some code missing from crypto4xx_alg.c? Also, IIRC, assoc

Re: [PATCH] AMCC Crypto4xx Device Driver v4]

2008-12-08 Thread Kim Phillips
On Mon, 08 Dec 2008 13:55:07 -0800 James Hsiao [EMAIL PROTECTED] wrote: + /* figure how many gd is needed */ + if (aad_len) { + num_gd = get_sg_count(assoc, aad_len) + + get_sg_count(src, datalen); this is dead code - aad_len is never non-zero -

Re: Runaway loop with the current git.

2008-12-08 Thread Kay Sievers
On Tue, Dec 9, 2008 at 02:09, Theodore Tso [EMAIL PROTECTED] wrote: On Mon, Dec 08, 2008 at 04:35:20AM +0100, Kay Sievers wrote: Sure, if we can make userspace behave nicely, I'm all for doing it. On the other hand, I think it's a good thing to provide a sane environment by the kernel for any