Re: [PATCH] Export symbol ksize()

2009-02-12 Thread Matt Mackall
On Fri, 2009-02-13 at 07:09 +0800, Herbert Xu wrote: > On Fri, Feb 13, 2009 at 12:10:45AM +1100, Nick Piggin wrote: > > > > I would be interested to know how that goes. You always have this > > circular issue that if a little more space helps significantly, then > > maybe it is a good idea to expl

Re: [PATCH] Export symbol ksize()

2009-02-12 Thread Herbert Xu
On Thu, Feb 12, 2009 at 05:55:04PM +0200, Pekka Enberg wrote: > > OK, fair enough, I applied Kirill's patch. Thanks. Thanks Pekka! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herb

Re: [PATCH] Export symbol ksize()

2009-02-12 Thread Herbert Xu
On Fri, Feb 13, 2009 at 12:10:45AM +1100, Nick Piggin wrote: > > I would be interested to know how that goes. You always have this > circular issue that if a little more space helps significantly, then > maybe it is a good idea to explicitly ask for those bytes. Of course > that larger allocation

Re: [PATCH] Export symbol ksize()

2009-02-12 Thread Pekka Enberg
On Thu, Feb 12, 2009 at 12:45:21PM +0200, Pekka Enberg wrote: > > > > Because the API was being widely abused in the nommu code, for example. > > I'd rather not add it back for this special case which can be handled > > otherwise. On Thu, 2009-02-12 at 18:50 +0800, Herbert Xu wrote: > I'm sorry b

Re: LRW endian issues?

2009-02-12 Thread Geert Uytterhoeven
On Tue, 10 Feb 2009, Herbert Xu wrote: > On Fri, Feb 06, 2009 at 11:18:46AM +0100, Geert Uytterhoeven wrote: > > Here's a backtrace from the RCU stall detector on PS3: > > > > | INFO: RCU detected CPU 1 stall (t=4294906597/2500 jiffies) > > | Call Trace: > > | [cc186fc0] [c000f850]

Re: LRW endian issues?

2009-02-12 Thread Geert Uytterhoeven
On Tue, 10 Feb 2009, Herbert Xu wrote: > On Fri, Feb 06, 2009 at 03:01:24PM +1100, Herbert Xu wrote: > > Geert Uytterhoeven wrote: > > > When running "modprobe tcrypt mode=10" on ppc64 (PS3), I get the following > > > error: > > > > > > | alg: skcipher: Test 8 failed on encryption for lrw(aes-gen

Re: [PATCH] crypto: compress - Add pcomp interface

2009-02-12 Thread Geert Uytterhoeven
On Tue, 10 Feb 2009, Herbert Xu wrote: > On Thu, Feb 05, 2009 at 05:24:51PM +0100, Geert Uytterhoeven wrote: > > > Well with the netlink parameters these can have variable lengths > > > depending on how many parameters the user supplies. > > > > How can this be exported to userspace? > > How does

Re: [PATCH] Export symbol ksize()

2009-02-12 Thread Nick Piggin
On Thursday 12 February 2009 21:50:34 Herbert Xu wrote: > On Thu, Feb 12, 2009 at 12:45:21PM +0200, Pekka Enberg wrote: > > Because the API was being widely abused in the nommu code, for example. > > I'd rather not add it back for this special case which can be handled > > otherwise. > > I'm sorry

Re: [Crypto] 2.6.29-rc4-git4 build failure crypto/async_tx/async_xor

2009-02-12 Thread Geert Uytterhoeven
On Thu, 12 Feb 2009, Sachin P. Sant wrote: > On a powerpc box 2.6.29-rc4-git4 randconfig build fails with : > > CC [M] crypto/async_tx/async_xor.o > crypto/async_tx/async_xor.c: In function async_xor_init: > crypto/async_tx/async_xor.c:313: error: size of array type name is negative > make[2]: *

Re: [PATCH] Export symbol ksize()

2009-02-12 Thread Herbert Xu
On Thu, Feb 12, 2009 at 12:45:21PM +0200, Pekka Enberg wrote: > > Because the API was being widely abused in the nommu code, for example. > I'd rather not add it back for this special case which can be handled > otherwise. I'm sorry but that's like banning the use of heaters just because they can

Re: [PATCH] Export symbol ksize()

2009-02-12 Thread Pekka Enberg
On Tue, Feb 10, 2009 at 04:06:53PM +0200, Pekka J Enberg wrote: > > Herbert, what do you think of this (untested) patch? Alternatively, we > > could do something like kfree_secure() but it seems overkill for this one > > call-site. On Thu, 2009-02-12 at 18:43 +0800, Herbert Xu wrote: > I don't u

Re: [PATCH] Export symbol ksize()

2009-02-12 Thread Herbert Xu
On Tue, Feb 10, 2009 at 04:06:53PM +0200, Pekka J Enberg wrote: > > Herbert, what do you think of this (untested) patch? Alternatively, we > could do something like kfree_secure() but it seems overkill for this one > call-site. I don't understand why you want to limit the use of ksize. If kmal