Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2010-01-17 Thread Richard Zidlicky
Hi, > The format-magic is not mentioned in Jari's description, but > is indeed used by Loop-AES. > > Compare loop-AES-v3.2h/glue.c:402: > > /* 4024 bits == 31 * 128 bit plaintext blocks + 56 bits of sector number */ > /* For version 3 on-disk format this really should be 4536 bits, but can't

Re: vmac test fails on s390

2010-01-17 Thread Herbert Xu
On Thu, Jan 14, 2010 at 02:05:30PM +, Jan Glauber wrote: > Hi, > > Jan 14 14:47:38 h42lp52 kernel: alg: hash: Test 1 failed for vmac(aes-s390) > Jan 14 14:47:38 h42lp52 kernel: : e7 79 33 b7 fd 8a d7 cb > > Looking at the digest from the failing test vector: > > .digest = "\xcb\xd7\x

Re: [PATCH 4/4] crypto: lmk2/lmk3 cipher block modes

2010-01-17 Thread Herbert Xu
On Mon, Dec 28, 2009 at 06:59:15PM +, Max Vozeler wrote: > This is a compatible implementation of the block chaining > modes used by the Loop-AES block device encryption system > (http://loop-aes.sf.net/). > > It implements two modes: lmk2 and lmk3. They correspond to > the modes used in Loop-

Re: [PATCH 3/4] crypto: md5 - Add export support

2010-01-17 Thread Herbert Xu
On Wed, Jan 13, 2010 at 06:37:06PM +0100, Max Vozeler wrote: > > This patch adds export/import support to md5. The exported type is > defined by struct md5_state. > > This is modeled after the equivalent change to sha1_generic. Applied to cryptodev. -- Visit Openswan at http://www.openswan.org/

Re: [PATCH] crypto: make Open Firmware device id constant

2010-01-17 Thread Herbert Xu
On Tue, Jan 12, 2010 at 09:01:45AM +0100, Németh Márton wrote: > From: Márton Németh > > The match_table field of the struct of_device_id is constant in > > so it is worth to make the initialization data also constant. Applied to cryptodev. Thanks. -- Visit Openswan at http://www.openswan.or

Re: [PATCH] crypto: gmac - Add RFC4543 wrapper for GCM

2010-01-17 Thread Herbert Xu
On Fri, Dec 04, 2009 at 05:31:43PM +0100, Tobias Brunner wrote: > > This patch adds the RFC4543 (GMAC) wrapper for GCM similar to the > existing RFC4106 wrapper. The main differences between GCM and GMAC are > the contents of the AAD and that the plaintext is empty for the latter. > > Signed-off-