Re: [PATCH 1/1] CRYPTO: Fix checkpatch errors warnings in cipher.c

2010-02-16 Thread Herbert Xu
On Tue, Feb 16, 2010 at 12:56:15PM +0100, Richard Hartmann wrote: Thus, I wanted to check if I should wait some more or what the general consensus of action in the crypto subtree is. And yes, I am aware that janitor work, and thus my patches, is very low priority. For the crypto tree at

Re: crypto_remove_spawns: BUG: unable to handle kernel NULL pointer dereference at 0000000000000018

2010-02-16 Thread Herbert Xu
On Mon, Feb 15, 2010 at 10:14:08AM +0200, Alexey Dobriyan wrote: Yes, ipcomp bug triggers almost immediately. Anyway, this is just description of what I do. Can you see if this patch makes it go away? This can happen when you're unloading aes just as an algorithm that uses aes (such as

Re: [PATCH 1/1] CRYPTO: Fix checkpatch errors warnings in cipher.c

2010-02-16 Thread Richard Hartmann
On Tue, Feb 16, 2010 at 13:00, Herbert Xu herb...@gondor.apana.org.au wrote: For the crypto tree at least I've got all your patches so you don't have to resend. OK, thank you very much. Expect more patches, in this case :) One more question on workflow, though.. I have been checking

Re: [PATCH] to fix vmac test fails on s390

2010-02-16 Thread Herbert Xu
On Thu, Feb 11, 2010 at 11:18:08AM +0800, Wang, Shane wrote: static struct hash_testvec aes_vmac128_tv_template[] = { { + .key= \x00\x01\x02\x03\x04\x05\x06\x07 + \x08\x09\x0a\x0b\x0c\x0d\x0e\x0f, + .plaintext = NULL, +#ifdef

Re: [PATCH] crypto/arc4: convert this stream cipher into a block cipher

2010-02-16 Thread Herbert Xu
On Fri, Feb 12, 2010 at 09:42:28AM +0100, Sebastian Andrzej Siewior wrote: -static void arc4_crypt(struct crypto_tfm *tfm, u8 *out, const u8 *in) +static void arc4_ivsetup(struct arc4_ctx *ctx, u8 *iv) { - struct arc4_ctx *ctx = crypto_tfm_ctx(tfm); + if (unlikely(!ctx-new_key)) +