Re: [PATCH] to fix vmac test fails on s390

2010-02-21 Thread Sebastian Andrzej Siewior
* Wang, Shane | 2010-02-21 13:32:49 [+0800]: --- a/crypto/vmac.cThu Feb 11 00:45:57 2010 -0800 +++ b/crypto/vmac.cSun Feb 21 02:23:01 2010 -0800 @@ -42,6 +42,8 @@ const u64 m63 = UINT64_C(0x7ff const u64 m63 = UINT64_C(0x7fff); /* 63-bit mask */ const u64

Re: [PATCH] crypto/arc4: convert this stream cipher into a block cipher

2010-02-21 Thread Sebastian Andrzej Siewior
* Herbert Xu | 2010-02-16 20:51:25 [+0800]: On Fri, Feb 12, 2010 at 09:42:28AM +0100, Sebastian Andrzej Siewior wrote: -static void arc4_crypt(struct crypto_tfm *tfm, u8 *out, const u8 *in) +static void arc4_ivsetup(struct arc4_ctx *ctx, u8 *iv) { -struct arc4_ctx *ctx =

Re: [PATCH] crypto/arc4: convert this stream cipher into a block cipher

2010-02-21 Thread Herbert Xu
On Sun, Feb 21, 2010 at 09:01:40PM +0100, Sebastian Andrzej Siewior wrote: I also destroy the user supplied IV. You don't care about that? :) So I have to know that someone called setkey() on this ctx but I can't leave hints. How about this? You extend the IV by one more byte, and use that

Re: [PATCH] crypto/arc4: convert this stream cipher into a block cipher

2010-02-21 Thread Herbert Xu
On Mon, Feb 22, 2010 at 08:45:47AM +0800, Herbert Xu wrote: How about this? You extend the IV by one more byte, and use that byte as a boolean flag to indicate whether the IV is valid. All users that cannot supply their own IVs can then set the IV to zero. When you see the zero flag in

RE: [PATCH] to fix vmac test fails on s390

2010-02-21 Thread Wang, Shane
Updated again and Resend This patch is to fix the vmac algorithm, add more test cases for vmac, and fix the test failure on some big endian system like s390. Signed-off-by: Shane Wang shane.w...@intel.com crypto/testmgr.h | 64 +--- crypto/vmac.c| 80