[PATCH] crypto: fix vmac test fails on s390 (v2)

2010-03-15 Thread Shane Wang
This patch is to fix the vmac algorithm, add more test cases for vmac, and fix the test failure on some big endian system like s390. Signed-off-by: Shane Wang --- crypto/testmgr.h | 64 -- crypto/vmac.c| 75 +---

Re: Converting mac80211 CCMP to packet-at-a-time processing

2010-03-15 Thread Pavel Roskin
On Sat, 2010-03-13 at 20:28 +0800, Herbert Xu wrote: > Pavel Roskin wrote: > > > > However, it's disappointing that the caller needs to deal explicitly > > with completions. The blkcipher API is much simpler. I would have hard > > time advocating a patch to CCMP that makes the code more complic

Re: [PATCH] to fix vmac test fails on s390

2010-03-15 Thread Herbert Xu
On Tue, Mar 16, 2010 at 01:25:54PM +0800, Wang, Shane wrote: > That should be simpler and better. OK can you please resubmit the patch? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana

RE: [PATCH] to fix vmac test fails on s390

2010-03-15 Thread Wang, Shane
That should be simpler and better. Thanks. Shane -Original Message- From: Herbert Xu [mailto:herb...@gondor.apana.org.au] Sent: 2010年3月2日 21:57 To: Wang, Shane Cc: Sebastian Andrzej Siewior; Jan Glauber; Cihula, Joseph; linux-crypto Subject: Re: [PATCH] to fix vmac test fails on s390 On

Re: ABLKCIPHER

2010-03-15 Thread Herbert Xu
On Mon, Mar 15, 2010 at 03:23:36PM +, Dimitrios Siganos wrote: > > Let's say I want to do the classic cbc(aes). The steps are: > 1) allocate a tfm object > 2) set the key > 3) set the iv > 4) encrypt as many times as needed > 5) cleanup > > I can do this without the giv functions. Do the giv ap

Re: ABLKCIPHER

2010-03-15 Thread Kim Phillips
On Mon, 15 Mar 2010 15:23:36 + Dimitrios Siganos wrote: > Herbert Xu wrote: > > Dimitrios Siganos wrote: > > > >> Hi, > >> > >> I am trying to write an ABLKCIPHER algorithm for my hardware crypto > >> engine and I have a few questions: > >> > >> 1) In struct ablkcipher_alg, what do these

Re: ABLKCIPHER

2010-03-15 Thread Dimitrios Siganos
Herbert Xu wrote: Dimitrios Siganos wrote: Hi, I am trying to write an ABLKCIPHER algorithm for my hardware crypto engine and I have a few questions: 1) In struct ablkcipher_alg, what do these fields do? I see some implementations use them and some not. Do I need to implement them?