Greg,
This pertains to commit 8ceee72808d1 (crypto: ghash-clmulni-intel -
use C implementation for setkey()) that has been pulled by Linus
during the current merge window.
It is missing two things:
- a cc to stable annotation
- a fix for the sparse warning below (change cast from __be64 to
On 04/03/2014 09:25 PM, Josh Cartwright wrote:
Nitworthy comments :).
On Thu, Apr 03, 2014 at 07:18:00PM +0300, Stanimir Varbanov wrote:
[..]
+++ b/drivers/crypto/qce/dma.c
[..]
+int qce_dma_request(struct device *dev, struct qce_dma_data *dma)
+{
+unsigned int memsize;
+void
Minor nitpicks.
On 03/04/14 17:17, Stanimir Varbanov wrote:
+#define REQ_SIZE 17 /* bit 20-17 */
I would have defined macros like this with _SHIFT at the end, something
like this:
#define REQ_SIZE_SHIFT 17
+#define REQ_SIZE_MASK (0xf
On Tue, Apr 01, 2014 at 08:48:24PM +0800, Herbert Xu wrote:
On Tue, Apr 01, 2014 at 02:37:20PM +0200, Ard Biesheuvel wrote:
On 1 April 2014 13:23, kbuild test robot fengguang...@intel.com wrote:
tree:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git
master
On 4 April 2014 14:25, Herbert Xu herb...@gondor.apana.org.au wrote:
On Tue, Apr 01, 2014 at 08:48:24PM +0800, Herbert Xu wrote:
On Tue, Apr 01, 2014 at 02:37:20PM +0200, Ard Biesheuvel wrote:
On 1 April 2014 13:23, kbuild test robot fengguang...@intel.com wrote:
tree:
On Fri, Apr 04, 2014 at 03:03:55PM +0200, Ard Biesheuvel wrote:
On 4 April 2014 14:25, Herbert Xu herb...@gondor.apana.org.au wrote:
On Tue, Apr 01, 2014 at 08:48:24PM +0800, Herbert Xu wrote:
On Tue, Apr 01, 2014 at 02:37:20PM +0200, Ard Biesheuvel wrote:
On 1 April 2014 13:23, kbuild
Hi Courtney,
Thanks for the comments!
On 04/04/2014 02:15 AM, Courtney Cavin wrote:
On Thu, Apr 03, 2014 at 06:18:00PM +0200, Stanimir Varbanov wrote:
This adds dmaengine and sg-list helper functions used by
other parts of the crypto driver.
Signed-off-by: Stanimir Varbanov
Hi Josh,
Thanks for the comments!
On 04/03/2014 09:19 PM, Josh Cartwright wrote:
Hey Stanimir-
Just a few comments/questions from a quick scan of your patchset:
On Thu, Apr 03, 2014 at 07:17:58PM +0300, Stanimir Varbanov wrote:
[..]
+++ b/drivers/crypto/qce/core.c
[..]
+
+static
Hi Srini,
Thanks for the comments.
On 04/04/2014 12:23 PM, Srinivas Kandagatla wrote:
Minor nitpicks.
On 03/04/14 17:17, Stanimir Varbanov wrote:
+#define REQ_SIZE17 /* bit 20-17 */
I would have defined macros like this with _SHIFT at the end, something
like this:
